Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2889)

Unified Diff: chrome/browser/android/vr_shell/gltf_parser.h

Issue 2775283004: Rendering Daydream controller in a fixed position. (Closed)
Patch Set: Moving code to more appropriate locations. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/vr_shell/gltf_asset.cc ('k') | chrome/browser/android/vr_shell/gltf_parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/gltf_parser.h
diff --git a/chrome/browser/android/vr_shell/gltf_parser.h b/chrome/browser/android/vr_shell/gltf_parser.h
index 63283363ce37f52f50752605dbaeee0233e6d452..6aee8afd417ad39b71340e8255deb8b1e73f4a20 100644
--- a/chrome/browser/android/vr_shell/gltf_parser.h
+++ b/chrome/browser/android/vr_shell/gltf_parser.h
@@ -33,13 +33,18 @@ class GltfParser {
// IO, and a base path must be specified.
std::unique_ptr<gltf::Asset> Parse(
const base::DictionaryValue& dict,
+ std::vector<std::unique_ptr<gltf::Buffer>>* buffers,
const base::FilePath& path = base::FilePath());
// Note: This function will perform IO.
- std::unique_ptr<gltf::Asset> Parse(const base::FilePath& gltf_path);
+ std::unique_ptr<gltf::Asset> Parse(
+ const base::FilePath& gltf_path,
+ std::vector<std::unique_ptr<gltf::Buffer>>* buffers);
private:
- bool ParseInternal(const base::DictionaryValue& dict);
- bool SetBuffers(const base::DictionaryValue& dict);
+ bool ParseInternal(const base::DictionaryValue& dict,
+ std::vector<std::unique_ptr<gltf::Buffer>>* buffers);
+ bool SetBuffers(const base::DictionaryValue& dict,
+ std::vector<std::unique_ptr<gltf::Buffer>>* buffers);
bool SetBufferViews(const base::DictionaryValue& dict);
bool SetAccessors(const base::DictionaryValue& dict);
bool SetMeshes(const base::DictionaryValue& dict);
« no previous file with comments | « chrome/browser/android/vr_shell/gltf_asset.cc ('k') | chrome/browser/android/vr_shell/gltf_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698