Issue 2775283002: Use Entity in native_data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2775283002: Use Entity in native_data. (Closed)

Created:
3 years, 9 months ago by Johnni Winther

Modified:
3 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use Entity in native_data. NativeBasicDataImpl and NativeDataImpl are now reusable for J/K-elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/5aa715b7a8a54ca2544dcdd4b56c755e1d6472cf

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -12 lines)			Patch
M	pkg/compiler/lib/src/common_elements.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend_usage.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/native_data.dart	View		5 chunks	+12 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/kernel/world_builder.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 8 months ago (2017-03-28 09:02:59 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5aa715b7a8a54ca2544dcdd4b56c755e1d6472cf (presubmit successful).