Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2775223004: NQE: Make params a class (Closed)
Patch Set: ps Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | net/nqe/network_quality_estimator_params.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index 5c2718a12b6df2eb8ba4763a739942f511798982..d0a900ee9c28b19f23de771eddd6c03cc75ac197 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -28,6 +28,7 @@
#include "net/nqe/external_estimate_provider.h"
#include "net/nqe/network_id.h"
#include "net/nqe/network_quality.h"
+#include "net/nqe/network_quality_estimator_params.h"
#include "net/nqe/network_quality_observation.h"
#include "net/nqe/network_quality_observation_source.h"
#include "net/nqe/network_quality_store.h"
@@ -536,8 +537,7 @@ class NET_EXPORT NetworkQualityEstimator
// the field trial parameters. For each effective connection type, a model
// (currently composed of a RTT threshold and a downlink throughput threshold)
// is provided by the field trial.
- void ObtainOperatingParams(
- const std::map<std::string, std::string>& variation_params);
+ void ObtainOperatingParams();
// Adds the default median RTT and downstream throughput estimate for the
// current connection type to the observation buffer.
@@ -650,6 +650,9 @@ class NET_EXPORT NetworkQualityEstimator
const char* GetNameForStatistic(int i) const;
+ // Params to config the network quality estimator.
RyanSturm 2017/03/28 17:23:11 s/config/configure/?
tbansal1 2017/03/29 18:17:51 Done.
+ const nqe::internal::NetworkQualityEstimatorParams params_;
+
// Determines if the requests to local host can be used in estimating the
// network quality. Set to true only for tests.
bool use_localhost_requests_;
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | net/nqe/network_quality_estimator_params.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698