Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: pkg/compiler/lib/src/kernel/world_builder.dart

Issue 2775223002: Derive CommonElements directly from ElementEnvironment. (Closed)
Patch Set: Fix. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/world_builder.dart
diff --git a/pkg/compiler/lib/src/kernel/world_builder.dart b/pkg/compiler/lib/src/kernel/world_builder.dart
index 758687d64031c8f1f5ccc3d4c7182ba1b86a7d3e..b9ca7ab16e1d1893c170ff8730c5d23b5a6c7862 100644
--- a/pkg/compiler/lib/src/kernel/world_builder.dart
+++ b/pkg/compiler/lib/src/kernel/world_builder.dart
@@ -71,7 +71,7 @@ class KernelWorldBuilder extends KernelElementAdapterMixin {
KernelWorldBuilder(this.reporter, ir.Program program)
: _env = new KEnv(program) {
_elementEnvironment = new KernelElementEnvironment(this);
- _commonElements = new KernelCommonElements(_elementEnvironment);
+ _commonElements = new CommonElementsImpl(_elementEnvironment);
ConstantEnvironment constants = new KernelConstantEnvironment(this);
_nativeBehaviorBuilder =
new KernelBehaviorBuilder(_commonElements, helpers, constants);
@@ -520,6 +520,9 @@ class KernelElementEnvironment implements ElementEnvironment {
KernelElementEnvironment(this.worldBuilder);
@override
+ DartType get dynamicType => const DynamicType();
+
+ @override
LibraryEntity get mainLibrary => worldBuilder._mainLibrary;
@override
@@ -598,46 +601,6 @@ class KernelElementEnvironment implements ElementEnvironment {
}
}
-/// [CommonElements] implementation based on [KernelWorldBuilder].
-class KernelCommonElements extends CommonElementsMixin {
- final ElementEnvironment environment;
-
- KernelCommonElements(this.environment);
-
- @override
- LibraryEntity get coreLibrary {
- return environment.lookupLibrary(Uris.dart_core, required: true);
- }
-
- @override
- DynamicType get dynamicType => const DynamicType();
-
- @override
- ClassEntity get nativeAnnotationClass {
- throw new UnimplementedError('KernelCommonElements.nativeAnnotationClass');
- }
-
- @override
- ClassEntity get patchAnnotationClass {
- throw new UnimplementedError('KernelCommonElements.patchAnnotationClass');
- }
-
- @override
- LibraryEntity get typedDataLibrary {
- throw new UnimplementedError('KernelCommonElements.typedDataLibrary');
- }
-
- @override
- LibraryEntity get mirrorsLibrary {
- throw new UnimplementedError('KernelCommonElements.mirrorsLibrary');
- }
-
- @override
- LibraryEntity get asyncLibrary {
- throw new UnimplementedError('KernelCommonElements.asyncLibrary');
- }
-}
-
/// Visitor that converts kernel dart types into [DartType].
class DartTypeConverter extends ir.DartTypeVisitor<DartType> {
final KernelWorldBuilder elementAdapter;
« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698