Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2775173002: MD Settings: hide some things from the a11y tree with role="none" so VoiceOver navigation works (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: hide some things from the a11y tree with role="none" so VoiceOver navigation works R=aboxhall@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2775173002 Cr-Commit-Position: refs/heads/master@{#460667} Committed: https://chromium.googlesource.com/chromium/src/+/7e98bef2f1ddeb6426397b626ea61ad6b1c8bef7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 25 (13 generated)
Dan Beam
3 years, 8 months ago (2017-03-27 06:24:06 UTC) #2
Dan Beam
ping
3 years, 8 months ago (2017-03-28 06:12:04 UTC) #7
Dan Beam
+dmazzoni@ if i could get a stamp from anybody that'd be great, this is blocking ...
3 years, 8 months ago (2017-03-29 12:45:03 UTC) #9
dmazzoni
lgtm What was the problem with VoiceOver? I wonder if we should look into fixing ...
3 years, 8 months ago (2017-03-29 15:16:01 UTC) #10
Dan Beam
On 2017/03/29 15:16:01, dmazzoni wrote: > lgtm > > What was the problem with VoiceOver? ...
3 years, 8 months ago (2017-03-29 23:31:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775173002/1
3 years, 8 months ago (2017-03-29 23:31:34 UTC) #13
Dan Beam
On 2017/03/29 23:31:33, Dan Beam (slow) wrote: > On 2017/03/29 15:16:01, dmazzoni wrote: > > ...
3 years, 8 months ago (2017-03-29 23:31:53 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/237561) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-03-29 23:35:17 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775173002/1
3 years, 8 months ago (2017-03-30 00:15:46 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-30 01:34:23 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2775173002/1
3 years, 8 months ago (2017-03-30 04:46:56 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 04:51:44 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e98bef2f1ddeb6426397b626ea6...

Powered by Google App Engine
This is Rietveld 408576698