|
|
Created:
3 years, 8 months ago by Dan Beam Modified:
3 years, 8 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: hide some things from the a11y tree with role="none" so VoiceOver navigation works
R=aboxhall@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2775173002
Cr-Commit-Position: refs/heads/master@{#460667}
Committed: https://chromium.googlesource.com/chromium/src/+/7e98bef2f1ddeb6426397b626ea61ad6b1c8bef7
Patch Set 1 #
Messages
Total messages: 25 (13 generated)
Description was changed from ========== MD Settings: hide some things from the a11y tree with role="none" so VoiceOver navigation works R=aboxhall@chromium.org BUG=none ========== to ========== MD Settings: hide some things from the a11y tree with role="none" so VoiceOver navigation works R=aboxhall@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ping
dbeam@chromium.org changed reviewers: + dmazzoni@chromium.org
+dmazzoni@ if i could get a stamp from anybody that'd be great, this is blocking a thing Laura discovered about md-settings + VoiceOver
lgtm What was the problem with VoiceOver? I wonder if we should look into fixing the underlying cause. role="none" removes that node from the a11y tree but not its descendants, I'm wondering what was wrong with that node in these cases
The CQ bit was checked by dbeam@chromium.org
On 2017/03/29 15:16:01, dmazzoni wrote: > lgtm > > What was the problem with VoiceOver? I wonder if we should > look into fixing the underlying cause. > > role="none" removes that node from the a11y tree but > not its descendants, I'm wondering what was wrong with > that node in these cases try navigation in md-settings with voiceover on canari. you can get through these nodes with VO+left/right/up/down
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/03/29 23:31:33, Dan Beam (slow) wrote: > On 2017/03/29 15:16:01, dmazzoni wrote: > > lgtm > > > > What was the problem with VoiceOver? I wonder if we should > > look into fixing the underlying cause. > > > > role="none" removes that node from the a11y tree but > > not its descendants, I'm wondering what was wrong with > > that node in these cases > > try navigation in md-settings with voiceover on canari. you can get through > these nodes with VO+left/right/up/down canary, can't get**
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder probably lacks capacity)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1490849187814210, "parent_rev": "15a130ea6aa5ccdd20d9bfdc960576d689807ba2", "commit_rev": "7e98bef2f1ddeb6426397b626ea61ad6b1c8bef7"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: hide some things from the a11y tree with role="none" so VoiceOver navigation works R=aboxhall@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: hide some things from the a11y tree with role="none" so VoiceOver navigation works R=aboxhall@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2775173002 Cr-Commit-Position: refs/heads/master@{#460667} Committed: https://chromium.googlesource.com/chromium/src/+/7e98bef2f1ddeb6426397b626ea6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7e98bef2f1ddeb6426397b626ea6... |