Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: third_party/WebKit/Source/core/animation/TimingInputTest.cpp

Issue 2775143002: Implement frames() timing function (Closed)
Patch Set: Fix behaviour outside input range [0,1] Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/TimingInputTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/TimingInputTest.cpp b/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
index 630f9e93f2f751111913912ab45dfaaa3e00ef71..5e9f6d8c477587c347a291a0f924a25f7a6e59a8 100644
--- a/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
+++ b/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
@@ -329,6 +329,11 @@ TEST(AnimationTimingInputTest, TimingInputTimingFunction) {
success)
.timing_function);
EXPECT_TRUE(success);
+ EXPECT_EQ(*FramesTimingFunction::Create(5),
+ *ApplyTimingInputString(scope.GetIsolate(), "easing", "frames(5)",
+ success)
+ .timing_function);
+ EXPECT_TRUE(success);
ApplyTimingInputString(scope.GetIsolate(), "easing", "", success);
EXPECT_FALSE(success);
@@ -338,6 +343,11 @@ TEST(AnimationTimingInputTest, TimingInputTimingFunction) {
ApplyTimingInputString(scope.GetIsolate(), "easing",
"cubic-bezier(2, 2, 0.3, 0.3)", success);
EXPECT_FALSE(success);
+ ApplyTimingInputString(scope.GetIsolate(), "easing", "frames(1)", success);
+ EXPECT_FALSE(success);
+ ApplyTimingInputString(scope.GetIsolate(), "easing", "frames(3, start)",
+ success);
+ EXPECT_FALSE(success);
ApplyTimingInputString(scope.GetIsolate(), "easing", "rubbish", success);
EXPECT_FALSE(success);
ApplyTimingInputNumber(scope.GetIsolate(), "easing", 2, success);

Powered by Google App Engine
This is Rietveld 408576698