Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Unified Diff: third_party/WebKit/Source/core/animation/TimingInputTest.cpp

Issue 2775143002: Implement frames() timing function (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/TimingInputTest.cpp
diff --git a/third_party/WebKit/Source/core/animation/TimingInputTest.cpp b/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
index de16c6678a6b52f5fdacf005ede6135c8b98cc41..de1fb62fc3d1410190bf19999212af4eaeaf0de8 100644
--- a/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
+++ b/third_party/WebKit/Source/core/animation/TimingInputTest.cpp
@@ -321,6 +321,11 @@ TEST(AnimationTimingInputTest, TimingInputTimingFunction) {
success)
.timingFunction);
EXPECT_TRUE(success);
+ EXPECT_EQ(
+ *FramesTimingFunction::create(5),
+ *applyTimingInputString(scope.isolate(), "easing", "frames(5)", success)
+ .timingFunction);
+ EXPECT_TRUE(success);
applyTimingInputString(scope.isolate(), "easing", "", success);
EXPECT_FALSE(success);
@@ -329,6 +334,11 @@ TEST(AnimationTimingInputTest, TimingInputTimingFunction) {
applyTimingInputString(scope.isolate(), "easing",
"cubic-bezier(2, 2, 0.3, 0.3)", success);
EXPECT_FALSE(success);
+ applyTimingInputString(scope.isolate(), "easing", "frames(1)", success);
+ EXPECT_FALSE(success);
+ applyTimingInputString(scope.isolate(), "easing", "frames(3, start)",
+ success);
+ EXPECT_FALSE(success);
applyTimingInputString(scope.isolate(), "easing", "rubbish", success);
EXPECT_FALSE(success);
applyTimingInputNumber(scope.isolate(), "easing", 2, success);

Powered by Google App Engine
This is Rietveld 408576698