Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: third_party/WebKit/LayoutTests/transitions/transitions-parsing.html

Issue 2775143002: Implement frames() timing function (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/transitions/transitions-parsing.html
diff --git a/third_party/WebKit/LayoutTests/transitions/transitions-parsing.html b/third_party/WebKit/LayoutTests/transitions/transitions-parsing.html
index 14b566f0245998d1b52c73ab689e40f66ea76073..c2d28e8d5d4aba0eacfa832781ba16c8487138f8 100644
--- a/third_party/WebKit/LayoutTests/transitions/transitions-parsing.html
+++ b/third_party/WebKit/LayoutTests/transitions/transitions-parsing.html
@@ -372,6 +372,12 @@ shouldBe("computedStyle.transitionTimingFunction", "'steps(5, start)'");
shouldBe("style.webkitTransitionTimingFunction", "'steps(5, start)'");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'steps(5, start)'");
+style.transitionTimingFunction = "frames(5)";
+shouldBe("style.transitionTimingFunction", "'frames(5)'");
+shouldBe("computedStyle.transitionTimingFunction", "'frames(5)'");
+shouldBe("style.webkitTransitionTimingFunction", "'frames(5)'");
+shouldBe("computedStyle.webkitTransitionTimingFunction", "'frames(5)'");
+
style.transitionProperty = "opacity, width";
style.transitionTimingFunction = "ease-in-out, ease-in";
@@ -462,6 +468,24 @@ shouldBe("computedStyle.transitionTimingFunction", "'ease'");
shouldBe("style.webkitTransitionTimingFunction", "''");
shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
+style.transitionTimingFunction = "frame(5)";
+shouldBe("style.transitionTimingFunction", "''");
+shouldBe("computedStyle.transitionTimingFunction", "'ease'");
+shouldBe("style.webkitTransitionTimingFunction", "''");
+shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
+
+style.transitionTimingFunction = "frames(1)";
+shouldBe("style.transitionTimingFunction", "''");
+shouldBe("computedStyle.transitionTimingFunction", "'ease'");
+shouldBe("style.webkitTransitionTimingFunction", "''");
+shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
+
+style.transitionTimingFunction = "frames(5, end)";
+shouldBe("style.transitionTimingFunction", "''");
+shouldBe("computedStyle.transitionTimingFunction", "'ease'");
+shouldBe("style.webkitTransitionTimingFunction", "''");
+shouldBe("computedStyle.webkitTransitionTimingFunction", "'ease'");
alancutter (OOO until 2018) 2017/03/29 04:58:31 I wish there were a helper function like shouldNot
suzyh_UTC10 (ex-contributor) 2017/04/04 01:02:03 Ack.
+
alancutter (OOO until 2018) 2017/03/29 04:58:30 Let's also test frames() for parse failure.
suzyh_UTC10 (ex-contributor) 2017/04/04 01:02:03 Done.
style.transitionTimingFunction = "red";
shouldBe("style.transitionTimingFunction", "''");
shouldBe("computedStyle.transitionTimingFunction", "'ease'");

Powered by Google App Engine
This is Rietveld 408576698