Implement frames() timing function

cc/animation/keyframed_animation_curve_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/animation/keyframed_animation_curve.h"
 
 #include "cc/animation/transform_operations.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/gfx/animation/tween.h"
@@ skipping 517 matching lines @@
   }
   EXPECT_FLOAT_EQ(num_steps,
                   curve->GetValue(base::TimeDelta::FromSecondsD(1.0)));
 
   for (float i = 0.5f; i <= num_steps; i += 1.0f) {
     const base::TimeDelta time = base::TimeDelta::FromSecondsD(i / num_steps);
     EXPECT_FLOAT_EQ(std::floor(i), curve->GetValue(time));
   }
 }
 
+// Tests a frames timing function.
+TEST(KeyframedAnimationCurveTest, FramesTimingFunction) {
+  std::unique_ptr<KeyframedFloatAnimationCurve> curve(
+      KeyframedFloatAnimationCurve::Create());
+  curve->AddKeyframe(FloatKeyframe::Create(base::TimeDelta(), 0.f,
+                                           FramesTimingFunction::Create(5)));
+  curve->AddKeyframe(
+      FloatKeyframe::Create(base::TimeDelta::FromSecondsD(1.0), 1.f, nullptr));
+
+  EXPECT_FLOAT_EQ(0.f, curve->GetValue(base::TimeDelta()));
+  EXPECT_FLOAT_EQ(0.f, curve->GetValue(base::TimeDelta::FromSecondsD(0.1999)));
+  EXPECT_FLOAT_EQ(0.25f,
+                  curve->GetValue(base::TimeDelta::FromSecondsD(0.2001)));
+  EXPECT_FLOAT_EQ(0.25f,
+                  curve->GetValue(base::TimeDelta::FromSecondsD(0.3999)));
+  EXPECT_FLOAT_EQ(0.5f, curve->GetValue(base::TimeDelta::FromSecondsD(0.4001)));
+  EXPECT_FLOAT_EQ(0.5f, curve->GetValue(base::TimeDelta::FromSecondsD(0.5999)));
+  EXPECT_FLOAT_EQ(0.75f,
+                  curve->GetValue(base::TimeDelta::FromSecondsD(0.6001)));
+  EXPECT_FLOAT_EQ(0.75f,
+                  curve->GetValue(base::TimeDelta::FromSecondsD(0.7999)));
+  EXPECT_FLOAT_EQ(1.f, curve->GetValue(base::TimeDelta::FromSecondsD(0.8001)));
+  EXPECT_FLOAT_EQ(1.f, curve->GetValue(base::TimeDelta::FromSecondsD(1.0)));

[alancutter (OOO until 2018), 2017/03/29 04:58:30]

These line wraps make the test a bit harder to read and verify, I'd consider
having a helper function to reduce the line length.

[suzyh_UTC10 (ex-contributor), 2017/04/04 01:02:02]

Rearranged. How's this?

git cl format has Opinions about how the expectations data should be formatted.
Let me know if this formatting is fine or if I should add incantations to force
it into a different format.

+}
+
 // Tests that animated bounds are computed as expected.
 TEST(KeyframedAnimationCurveTest, AnimatedBounds) {
   std::unique_ptr<KeyframedTransformAnimationCurve> curve(
       KeyframedTransformAnimationCurve::Create());
 
   TransformOperations operations1;
   curve->AddKeyframe(
       TransformKeyframe::Create(base::TimeDelta(), operations1, nullptr));
   operations1.AppendTranslate(2.0, 3.0, -1.0);
   curve->AddKeyframe(TransformKeyframe::Create(
@@ skipping 280 matching lines @@
   curve->AddKeyframe(
       FloatKeyframe::Create(base::TimeDelta::FromSecondsD(1.0), 2.f, nullptr));
   // Curve timing function producing timing outputs outside of range [0,1].
   curve->SetTimingFunction(
       CubicBezierTimingFunction::Create(0.5f, -0.5f, 0.5f, 1.5f));
 
   EXPECT_FLOAT_EQ(0.f, curve->GetValue(base::TimeDelta::FromSecondsD(0.25f)));
   EXPECT_FLOAT_EQ(2.f, curve->GetValue(base::TimeDelta::FromSecondsD(0.75f)));
 }
 
+// Tests that a frames timing function works as expected for inputs outside of
+// range [0,1]

[alancutter (OOO until 2018), 2017/03/29 04:58:30]

Bah these comments, they're just repeating the test name. No need to alter given
it's consistent.

[suzyh_UTC10 (ex-contributor), 2017/04/04 01:02:02]

Ack.

+TEST(KeyframedAnimationCurveTest, FramesTimingInputsOutsideZeroOneRange) {
+  std::unique_ptr<KeyframedFloatAnimationCurve> curve(
+      KeyframedFloatAnimationCurve::Create());
+  curve->AddKeyframe(FloatKeyframe::Create(base::TimeDelta(), 0.f,
+                                           FramesTimingFunction::Create(5)));
+  curve->AddKeyframe(
+      FloatKeyframe::Create(base::TimeDelta::FromSecondsD(1.0), 2.f, nullptr));
+  // Curve timing function producing timing outputs outside of range [0,1].
+  curve->SetTimingFunction(
+      CubicBezierTimingFunction::Create(0.5f, -0.5f, 0.5f, 1.5f));
+
+  EXPECT_FLOAT_EQ(0.f, curve->GetValue(base::TimeDelta::FromSecondsD(0.25f)));
+  EXPECT_FLOAT_EQ(2.f, curve->GetValue(base::TimeDelta::FromSecondsD(0.75f)));
+}
+
 // Tests that an animation with a curve timing function and multiple keyframes
 // works as expected.
 TEST(KeyframedAnimationCurveTest, CurveTimingMultipleKeyframes) {
   std::unique_ptr<KeyframedFloatAnimationCurve> curve(
       KeyframedFloatAnimationCurve::Create());
   curve->AddKeyframe(FloatKeyframe::Create(base::TimeDelta(), 0.f, nullptr));
   curve->AddKeyframe(
       FloatKeyframe::Create(base::TimeDelta::FromSecondsD(1.f), 1.f, nullptr));
   curve->AddKeyframe(
       FloatKeyframe::Create(base::TimeDelta::FromSecondsD(2.f), 3.f, nullptr));
@@ skipping 76 matching lines @@
               curve->GetValue(base::TimeDelta::FromSecondsD(scale * 3.5f)),
               0.01f);
   EXPECT_FLOAT_EQ(9.f,
                   curve->GetValue(base::TimeDelta::FromSecondsD(scale * 4.f)));
   EXPECT_FLOAT_EQ(9.f,
                   curve->GetValue(base::TimeDelta::FromSecondsD(scale * 5.f)));
 }
 
 }  // namespace
 }  // namespace cc