Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2775073002: Fix analyzer tests when run in checked mode. (Closed)

Created:
3 years, 9 months ago by devoncarew
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix analyzer tests when run in checked mode. BUG= Committed: https://github.com/dart-lang/sdk/commit/0fcb91aa06f5adea38bc23044e5d500718746933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/analyzer_cli/test/reporter_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
The mock for this test evaluates 'options.color' to null; follow up from https://codereview.chromium.org/2775633002/. (TBR)
3 years, 9 months ago (2017-03-25 22:34:20 UTC) #2
devoncarew
Committed patchset #1 (id:1) manually as 0fcb91aa06f5adea38bc23044e5d500718746933 (presubmit successful).
3 years, 9 months ago (2017-03-25 22:34:45 UTC) #4
Brian Wilkerson
3 years, 8 months ago (2017-03-26 14:47:52 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698