content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2775013002: Add a UMA counter for tap disambiguation result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2775013002: Add a UMA counter for tap disambiguation result. (Closed)

Patch Set: Make TappedInside the last value for possible append of subdivision of it later Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 2a2b5993baf93fca8d61ee25615cfa2f191a5217..f383a61fc7a87b23f501a6b465edc8efbb5beeea 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1374,7 +1374,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa

public boolean onKeyUp(int keyCode, KeyEvent event) {

if (mPopupZoomer.isShowing() && keyCode == KeyEvent.KEYCODE_BACK) {

- mPopupZoomer.hide(true);

+ mPopupZoomer.backButtonPressed();

return true;

}

return mContainerViewInternals.super_onKeyUp(keyCode, event);

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java » ('j') | no next file with comments »