Added plumbing to transport the frame name between RenderViewHost and the Webkit layer.

chrome/renderer/render_view.cc

Index: chrome/renderer/render_view.cc
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index 9ff9ccc1f2555032cb907360b33b6637666e2b58..d25a7c32ba447c26217cf79d2f002fd27a20c8a2 100755
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -467,7 +467,8 @@ RenderView* RenderView::Create(
     const WebPreferences& webkit_prefs,
     SharedRenderViewCounter* counter,
     int32 routing_id,
-    int64 session_storage_namespace_id) {
+    int64 session_storage_namespace_id,
+    const string16& frame_name) {
   DCHECK(routing_id != MSG_ROUTING_NONE);
   scoped_refptr<RenderView> view = new RenderView(render_thread, webkit_prefs,
                                                   session_storage_namespace_id);
@@ -475,7 +476,8 @@ RenderView* RenderView::Create(
              opener_id,
              renderer_prefs,
              counter,
-             routing_id);  // adds reference
+             routing_id,
+             frame_name);  // adds reference
   return view;
 }
 
@@ -510,7 +512,8 @@ void RenderView::Init(gfx::NativeViewId parent_hwnd,
                       int32 opener_id,
                       const RendererPreferences& renderer_prefs,
                       SharedRenderViewCounter* counter,
-                      int32 routing_id) {
+                      int32 routing_id,
+                      const string16& frame_name) {
   DCHECK(!webview());
 
   if (opener_id != MSG_ROUTING_NONE)
@@ -531,6 +534,9 @@ void RenderView::Init(gfx::NativeViewId parent_hwnd,
   Singleton<ViewMap>::get()->insert(std::make_pair(webview(), this));
   webkit_preferences_.Apply(webview());
   webview()->initializeMainFrame(this);
+  // TODO(atwilson): Enable this when setName() becomes available upstream.
+  // if (!frame_name.empty)
+  //   webview()->mainFrame()->setName(frame_name);
   webview()->setDevToolsAgent(
       WebDevToolsAgent::create(webview(), devtools_agent_.get()));
 
@@ -1561,9 +1567,18 @@ void RenderView::OnMissingPluginStatus(
 
 // WebKit::WebViewClient ------------------------------------------------------
 
+// TODO(atwilson): Remove this older API when we've pushed the related changes
+// upstream.
 WebView* RenderView::createView(
     WebFrame* creator,
     const WebWindowFeatures& features) {
+  return createView(creator, features, WebString());
+}
+
+WebView* RenderView::createView(
+    WebFrame* creator,
+    const WebWindowFeatures& features,
+    const WebString& frame_name) {
   // Check to make sure we aren't overloading on popups.
   if (shared_popup_counter_->data > kMaximumNumberOfUnacknowledgedPopups)
     return NULL;
@@ -1572,19 +1587,20 @@ WebView* RenderView::createView(
   // message from the Browser process explicitly allowing it.
   script_can_close_ = false;
 
+  ViewHostMsg_CreateWindow_Params params;
+  params.opener_id = routing_id_;
+  params.user_gesture = creator->isProcessingUserGesture();
+  params.window_container_type = WindowFeaturesToContainerType(features);
+  params.session_storage_namespace_id = session_storage_namespace_id_;
+  params.frame_name = frame_name;
+
   int32 routing_id = MSG_ROUTING_NONE;
-  bool user_gesture = creator->isProcessingUserGesture();
-  bool opener_suppressed = creator->willSuppressOpenerInNewFrame();
   int64 cloned_session_storage_namespace_id;
+  bool opener_suppressed = creator->willSuppressOpenerInNewFrame();
 
   render_thread_->Send(
       new ViewHostMsg_CreateWindow(
-          routing_id_,
-          user_gesture,
-          WindowFeaturesToContainerType(features),
-          session_storage_namespace_id_,
-          &routing_id,
-          &cloned_session_storage_namespace_id));
+          params, &routing_id, &cloned_session_storage_namespace_id));

[rafaelw, 2010/06/10 22:48:05]

start params on previous line. indent to align on second line with open paren.

   if (routing_id == MSG_ROUTING_NONE)
     return NULL;
 
@@ -1595,8 +1611,9 @@ WebView* RenderView::createView(
                                         webkit_preferences_,
                                         shared_popup_counter_,
                                         routing_id,
-                                        cloned_session_storage_namespace_id);
-  view->opened_by_user_gesture_ = user_gesture;
+                                        cloned_session_storage_namespace_id,
+                                        frame_name);
+  view->opened_by_user_gesture_ = params.user_gesture;
 
   // Record whether the creator frame is trying to suppress the opener field.
   view->opener_suppressed_ = opener_suppressed;