Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: chrome/browser/tab_contents/background_contents.h

Issue 2775003: Added plumbing to transport the frame name between RenderViewHost and the Webkit layer. (Closed)
Patch Set: Added plumbing from chrome -> webkit api. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/tab_contents/background_contents.h
diff --git a/chrome/browser/tab_contents/background_contents.h b/chrome/browser/tab_contents/background_contents.h
index e2542ad8901ca5f2285139dadbf1170cc96c936d..619deb468321f10b1c140e419ce89150862b08c0 100644
--- a/chrome/browser/tab_contents/background_contents.h
+++ b/chrome/browser/tab_contents/background_contents.h
@@ -31,7 +31,8 @@ class BackgroundContents : public RenderViewHostDelegate,
public JavaScriptMessageBoxClient {
public:
BackgroundContents(SiteInstance* site_instance,
- int routing_id);
+ int routing_id,
+ const string16& frame_name);
~BackgroundContents();
// Provide access to the RenderViewHost for the
@@ -44,6 +45,11 @@ class BackgroundContents : public RenderViewHostDelegate,
virtual ViewType::Type GetRenderViewType() const {
return ViewType::BACKGROUND_CONTENTS;
}
+
+ virtual string16 GetRenderViewFrameName() const {
+ return frame_name_;
+ }
+
virtual int GetBrowserWindowID() const {
return extension_misc::kUnknownWindowId;
}
@@ -67,7 +73,8 @@ class BackgroundContents : public RenderViewHostDelegate,
// RenderViewHostDelegate::View
virtual void CreateNewWindow(
int route_id,
- WindowContainerType window_container_type);
+ WindowContainerType window_container_type,
+ const string16& frame_name);
virtual void CreateNewWidget(int route_id, WebKit::WebPopupType popup_type);
virtual void ShowCreatedWindow(int route_id,
WindowOpenDisposition disposition,
@@ -118,6 +125,11 @@ class BackgroundContents : public RenderViewHostDelegate,
// The URL being hosted.
GURL url_;
+ // The name of the frame associated with this BC's RenderView (used when
rafaelw 2010/06/10 22:48:05 frame -> top-level frame
+ // restoring BackgroundContents at startup, so they are re-launched with
+ // the correct name).
+ string16 frame_name_;
+
NotificationRegistrar registrar_;
DISALLOW_COPY_AND_ASSIGN(BackgroundContents);

Powered by Google App Engine
This is Rietveld 408576698