Added plumbing to transport the frame name between RenderViewHost and the Webkit layer.

chrome/browser/renderer_host/render_view_host_delegate.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 #define CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 75 matching lines @@
 
   class View {
    public:
     // The page is trying to open a new page (e.g. a popup window). The
     // window should be created associated with the given route, but it should
     // not be shown yet. That should happen in response to ShowCreatedWindow.
     // |window_container_type| describes the type of RenderViewHost container
     // that is requested -- in particular, the window.open call may have
     // specified 'background' and 'persistent' in the feature string.
     //
+    // The passed frame_name parameter is the _name_ parameter that was passed

[rafaelw, 2010/06/10 22:48:05]

nit: The passed frame_name parameter -> |frame_name|; _name_ -> name

+    // to window.open(), and will be empty if none was passed.
+    //
     // Note: this is not called "CreateWindow" because that will clash with
     // the Windows function which is actually a #define.
     //
     // NOTE: this takes ownership of @modal_dialog_event
     virtual void CreateNewWindow(
         int route_id,
-        WindowContainerType window_container_type) = 0;
+        WindowContainerType window_container_type,
+        const string16& frame_name) = 0;
 
     // The page is trying to open a new widget (e.g. a select popup). The
     // widget should be created associated with the given route, but it should
     // not be shown yet. That should happen in response to ShowCreatedWidget.
     // |popup_type| indicates if the widget is a popup and what kind of popup it
     // is (select, autofill...).
     virtual void CreateNewWidget(int route_id,
                                  WebKit::WebPopupType popup_type) = 0;
 
     // Show a previously created page with the specified disposition and bounds.
@@ skipping 355 matching lines @@
   // not a TabContents, returns NULL.
   virtual TabContents* GetAsTabContents();
 
   // Return id number of browser window which this object is attached to. If no
   // browser window is attached to, just return -1.
   virtual int GetBrowserWindowID() const = 0;
 
   // Return type of RenderView which is attached with this object.
   virtual ViewType::Type GetRenderViewType() const = 0;
 
+  // Return the desired name of the frame that will be associated with the
+  // RenderView.
+  virtual string16 GetRenderViewFrameName() const { return string16(); }

[rafaelw, 2010/06/10 22:48:05]

This feels kinda wrong. I think providing frame_name to RVH::CreateRenderView
would be more in keeping with the existing code. Is there a reason to prefer
doing it this way? If so, please also just check with Darin or Brettw (they
don't need to review this entire CL -- I'd just wanted to know that they're ok
with this addition to RVHD).

[Andrew T Wilson, 2010/06/11 04:24:01]

I don't have a strong motivation or preference either way (this was the issue I
emailed you about). Darin didn't have time to look at this right now, but his
brief comments seemed to indicate that he agreed with you, so I'm taking your
suggestion and changing this to be a param passed to CreateRenderView() instead.

+
   // The RenderView is being constructed (message sent to the renderer process
   // to construct a RenderView).  Now is a good time to send other setup events
   // to the RenderView.  This precedes any other commands to the RenderView.
   virtual void RenderViewCreated(RenderViewHost* render_view_host) {}
 
   // The RenderView has been constructed.
   virtual void RenderViewReady(RenderViewHost* render_view_host) {}
 
   // The RenderView died somehow (crashed or was killed by the user).
   virtual void RenderViewGone(RenderViewHost* render_view_host) {}
@@ skipping 162 matching lines @@
   virtual bool IsExternalTabContainer() const;
 
   // The RenderView has inserted one css file into page.
   virtual void DidInsertCSS() {}
 
   // A different node in the page got focused.
   virtual void FocusedNodeChanged() {}
 };
 
 #endif  // CHROME_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_DELEGATE_H_