Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2774993002: Standalone support for AOT as dylibs on Fuchsia. (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Standalone support for AOT as dylibs on Fuchsia. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/a42b802bccdc3489a3fbe54ebd8a5622160de4dc

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : Use compiled_action #

Patch Set 5 : gn format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -3 lines) Patch
M runtime/bin/BUILD.gn View 1 2 3 4 2 chunks +35 lines, -1 line 0 comments Download
M runtime/bin/extensions_fuchsia.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rmacnak
3 years, 9 months ago (2017-03-24 20:53:25 UTC) #2
zra
https://codereview.chromium.org/2774993002/diff/40001/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2774993002/diff/40001/runtime/bin/BUILD.gn#newcode711 runtime/bin/BUILD.gn:711: action("hello_fuchsia_assembly") { Can this use compiled_action? https://github.com/dart-lang/sdk/blob/master/build/compiled_action.gni
3 years, 9 months ago (2017-03-24 21:02:37 UTC) #3
rmacnak
https://codereview.chromium.org/2774993002/diff/40001/runtime/bin/BUILD.gn File runtime/bin/BUILD.gn (right): https://codereview.chromium.org/2774993002/diff/40001/runtime/bin/BUILD.gn#newcode711 runtime/bin/BUILD.gn:711: action("hello_fuchsia_assembly") { On 2017/03/24 21:02:37, zra wrote: > Can ...
3 years, 9 months ago (2017-03-24 21:24:15 UTC) #4
zra
lgtm
3 years, 9 months ago (2017-03-24 21:28:19 UTC) #5
rmacnak
3 years, 9 months ago (2017-03-24 21:52:25 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
a42b802bccdc3489a3fbe54ebd8a5622160de4dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698