Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7269)

Unified Diff: chrome/browser/android/vr_shell/vr_shell_delegate.cc

Issue 2774933003: Fixes WebVR presentation from within VRShell. (Closed)
Patch Set: Rebased on ToT, nits Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/vr_shell/vr_shell_delegate.h ('k') | device/vr/android/gvr/gvr_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/vr_shell_delegate.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell_delegate.cc b/chrome/browser/android/vr_shell/vr_shell_delegate.cc
index c9a3d1973573622ae295f1977ff8da5dbca3ce23..5cbf5f66be3a7acbaade022bb35560be335ef555 100644
--- a/chrome/browser/android/vr_shell/vr_shell_delegate.cc
+++ b/chrome/browser/android/vr_shell/vr_shell_delegate.cc
@@ -7,6 +7,7 @@
#include <utility>
#include "base/android/jni_android.h"
+#include "base/callback_helpers.h"
#include "chrome/browser/android/vr_shell/non_presenting_gvr_delegate.h"
#include "device/vr/android/gvr/gvr_device.h"
#include "device/vr/android/gvr/gvr_device_provider.h"
@@ -28,6 +29,9 @@ VrShellDelegate::~VrShellDelegate() {
device_provider_->Device()->OnExitPresent();
device_provider_->Device()->OnDelegateChanged();
}
+ if (!present_callback_.is_null()) {
+ base::ResetAndReturn(&present_callback_).Run(false);
+ }
}
device::GvrDelegateProvider* VrShellDelegate::CreateVrShellDelegate() {
@@ -62,6 +66,12 @@ void VrShellDelegate::SetPresentingDelegate(
}
presenting_delegate_->UpdateVSyncInterval(timebase_nanos_, interval_seconds_);
+
+ if (pending_successful_present_request_) {
+ presenting_delegate_->SetSubmitClient(std::move(submit_client_));
+ base::ResetAndReturn(&present_callback_).Run(true);
+ pending_successful_present_request_ = false;
+ }
}
void VrShellDelegate::RemoveDelegate() {
@@ -75,10 +85,21 @@ void VrShellDelegate::RemoveDelegate() {
void VrShellDelegate::SetPresentResult(JNIEnv* env,
const JavaParamRef<jobject>& obj,
- jboolean result) {
+ jboolean success) {
CHECK(!present_callback_.is_null());
- present_callback_.Run(result);
- present_callback_.Reset();
+ if (success && !presenting_delegate_) {
+ // We have to wait until the GL thread is ready since we have to pass it
+ // the VRSubmitFrameClient.
+ pending_successful_present_request_ = true;
+ return;
+ }
+
+ if (success) {
+ presenting_delegate_->SetSubmitClient(std::move(submit_client_));
+ }
+
+ base::ResetAndReturn(&present_callback_).Run(success);
+ pending_successful_present_request_ = false;
}
void VrShellDelegate::DisplayActivate(JNIEnv* env,
@@ -121,10 +142,6 @@ void VrShellDelegate::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
delete this;
}
-device::mojom::VRSubmitFrameClientPtr VrShellDelegate::TakeSubmitFrameClient() {
- return std::move(submit_client_);
-}
-
void VrShellDelegate::SetDeviceProvider(
device::GvrDeviceProvider* device_provider) {
if (device_provider_ == device_provider)
« no previous file with comments | « chrome/browser/android/vr_shell/vr_shell_delegate.h ('k') | device/vr/android/gvr/gvr_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698