Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2774843002: Pass AccessControlStatus to compileModule() (Closed)
Patch Set: const Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 5c4d414adb0012c17391889547863f8be51acc6c..0ddce2b38c0953e5c5f331490f1f3938d367b144 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -498,19 +498,21 @@ v8::MaybeLocal<v8::Script> V8ScriptRunner::compileScript(
v8::MaybeLocal<v8::Module> V8ScriptRunner::compileModule(
v8::Isolate* isolate,
const String& source,
- const String& fileName) {
+ const String& fileName,
+ AccessControlStatus accessControlStatus) {
TRACE_EVENT1("v8", "v8.compileModule", "fileName", fileName.utf8());
// TODO(adamk): Add Inspector integration?
// TODO(adamk): Pass more info into ScriptOrigin.
- v8::ScriptOrigin origin(v8String(isolate, fileName),
- v8::Integer::New(isolate, 0), // line_offset
- v8::Integer::New(isolate, 0), // col_offset
- v8Boolean(true, isolate), // accessControlStatus
- v8::Local<v8::Integer>(), // script id
- v8String(isolate, ""), // source_map_url
- v8Boolean(false, isolate), // accessControlStatus
- v8Boolean(false, isolate), // is_wasm
- v8Boolean(true, isolate)); // is_module
+ v8::ScriptOrigin origin(
+ v8String(isolate, fileName), v8::Integer::New(isolate, 0), // line_offset
+ v8::Integer::New(isolate, 0), // col_offset
+ v8Boolean(accessControlStatus == SharableCrossOrigin, isolate),
+ v8::Local<v8::Integer>(), // script id
+ v8String(isolate, ""), // source_map_url
+ v8Boolean(accessControlStatus == OpaqueResource, isolate),
+ v8Boolean(false, isolate), // is_wasm
+ v8Boolean(true, isolate)); // is_module
+
v8::ScriptCompiler::Source scriptSource(v8String(isolate, source), origin);
return v8::ScriptCompiler::CompileModule(isolate, &scriptSource);
}
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h ('k') | third_party/WebKit/Source/core/dom/Modulator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698