Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: services/BUILD.gn

Issue 2774783003: [DeviceService] Add service tests for VibrationManager. (Closed)
Patch Set: Let service_test app itself register mojo JNIs Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/BUILD.gn
diff --git a/services/BUILD.gn b/services/BUILD.gn
index 7ac2551e21811a3acc91e962e2283bed1def020d..52a819f38bc6f23c04ee6c52bf9ab4cdc5acb8c5 100644
--- a/services/BUILD.gn
+++ b/services/BUILD.gn
@@ -23,8 +23,12 @@ service_test("service_unittests") {
]
if (is_android) {
- # Some tests need to initialize V8.
- deps += [ "//v8:v8_external_startup_data_assets" ]
+ deps += [
+ "//services/device:java",
Ken Rockot(use gerrit already) 2017/04/10 21:29:32 Can this not just be a public_deps in //services/d
+
+ # Some tests need to initialize V8.
+ "//v8:v8_external_startup_data_assets",
+ ]
} else {
# NOTE: We do not currently support standalone service binaries on Android,
# so any tests which use the ServiceTest framework to connect to standalone
@@ -38,6 +42,7 @@ service_test("service_unittests") {
catalog("service_unittests_catalog") {
testonly = true
catalog_deps = [
+ "//services/device:tests_catalog",
"//services/preferences:tests_catalog",
"//services/video_capture:tests_catalog",
]

Powered by Google App Engine
This is Rietveld 408576698