Issue 2774713002: Remove outdated special handling of 'void' when parsing class members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2774713002: Remove outdated special handling of 'void' when parsing class members. (Closed)

Created:
3 years, 9 months ago by regis

Modified:
3 years, 9 months ago

Reviewers:
Florian Schneider, floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove outdated special handling of 'void' when parsing class members. This caused parsing of 'void Function() field;' to fail. No regression test was added since lots of them are about to land with this cl: https://codereview.chromium.org/2707033004 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/3b33596ab0a9efe885fb4de9054a5c369e16c776

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -24 lines)			Patch
	M	runtime/vm/parser.cc	View		1 chunk	+15 lines, -24 lines	0 comments	Download

Total messages: 6 (2 generated)

regis

3 years, 9 months ago (2017-03-23 17:49:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3b33596ab0a9efe885fb4de9054a5c369e16c776 (presubmit successful).