[Remote suggestions] Refactor the scheduler

components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "components/ntp_snippets/remote/scheduling_remote_suggestions_provider.h"
+#include "components/ntp_snippets/remote/remote_suggestions_scheduler_impl.h"
 
 #include <memory>
 #include <set>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
 #include "base/test/simple_test_clock.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "base/time/clock.h"
-#include "base/time/default_clock.h"
 #include "base/time/time.h"
 #include "components/ntp_snippets/features.h"
 #include "components/ntp_snippets/ntp_snippets_constants.h"
 #include "components/ntp_snippets/pref_names.h"
 #include "components/ntp_snippets/remote/persistent_scheduler.h"
 #include "components/ntp_snippets/remote/remote_suggestions_provider.h"
 #include "components/ntp_snippets/remote/test_utils.h"
 #include "components/ntp_snippets/status.h"
 #include "components/ntp_snippets/user_classifier.h"
 #include "components/prefs/pref_registry_simple.h"
@@ skipping 76 matching lines @@
   MOCK_METHOD1(DismissSuggestion, void(const ContentSuggestion::ID&));
   MOCK_METHOD2(FetchSuggestionImage,
                void(const ContentSuggestion::ID&, const ImageFetchedCallback&));
   MOCK_METHOD2(GetDismissedSuggestionsForDebugging,
                void(Category, const DismissedSuggestionsCallback&));
   MOCK_METHOD0(OnSignInStateChanged, void());
 };
 
 }  // namespace
 
-class SchedulingRemoteSuggestionsProviderTest : public ::testing::Test {
+class RemoteSuggestionsSchedulerImplTest : public ::testing::Test {
  public:
-  SchedulingRemoteSuggestionsProviderTest()
+  RemoteSuggestionsSchedulerImplTest()
       :  // For the test we enabled all trigger types.
         default_variation_params_{{"scheduler_trigger_types",
                                    "persistent_scheduler_wake_up,ntp_opened,"
                                    "browser_foregrounded,browser_cold_start"}},
         params_manager_(ntp_snippets::kStudyName,
                         default_variation_params_,
                         {kArticleSuggestionsFeature.name}),
-        underlying_provider_(nullptr),
-        scheduling_provider_(nullptr),
+        provider_(nullptr),
+        scheduler_(nullptr),

[Marc Treib, 2017/03/27 11:31:01]

nit: unique_ptrs initialize themselves to nullptr

[jkrcal, 2017/03/27 14:09:31]

Done.

         user_classifier_(/*pref_service=*/nullptr,
                          base::MakeUnique<base::DefaultClock>()) {
-    SchedulingRemoteSuggestionsProvider::RegisterProfilePrefs(
+    RemoteSuggestionsSchedulerImpl::RegisterProfilePrefs(
         utils_.pref_service()->registry());
     RequestThrottler::RegisterProfilePrefs(utils_.pref_service()->registry());
     // TODO(jkrcal) Create a static function in EulaAcceptedNotifier that
     // registers this pref and replace the call in browser_process_impl.cc & in
     // eula_accepted_notifier_unittest.cc with the new static function.
     local_state_.registry()->RegisterBooleanPref(::prefs::kEulaAccepted, false);
     ResetProvider();
   }
 
   void ResetProvider() {
-    auto underlying_provider =
-        base::MakeUnique<StrictMock<MockRemoteSuggestionsProvider>>(
-            /*observer=*/nullptr);
-    underlying_provider_ = underlying_provider.get();
+    provider_ = base::MakeUnique<StrictMock<MockRemoteSuggestionsProvider>>(
+        /*observer=*/nullptr);
 
     auto test_clock = base::MakeUnique<base::SimpleTestClock>();
     test_clock_ = test_clock.get();
     test_clock_->SetNow(base::Time::Now());
 
-    scheduling_provider_ =
-        base::MakeUnique<SchedulingRemoteSuggestionsProvider>(
-            /*observer=*/nullptr, std::move(underlying_provider),
-            &persistent_scheduler_, &user_classifier_, utils_.pref_service(),
-            &local_state_, std::move(test_clock));
+    scheduler_ = base::MakeUnique<RemoteSuggestionsSchedulerImpl>(
+        &persistent_scheduler_, &user_classifier_, utils_.pref_service(),
+        &local_state_, std::move(test_clock));
+    scheduler_->set_provider(provider_.get());
   }
 
   void SetVariationParameter(const std::string& param_name,
                              const std::string& param_value) {
     std::map<std::string, std::string> params = default_variation_params_;
     params[param_name] = param_value;
 
     params_manager_.ClearAllVariationParams();
     params_manager_.SetVariationParamsWithFeatureAssociations(
         ntp_snippets::kStudyName, params,
@@ skipping 17 matching lines @@
           fetch_done,
       Status status_code,
       std::vector<ContentSuggestion> suggestions) {
     fetch_done->Call(status_code, suggestions);
   }
 
  protected:
   std::map<std::string, std::string> default_variation_params_;
   variations::testing::VariationParamsManager params_manager_;
   StrictMock<MockPersistentScheduler> persistent_scheduler_;
-  StrictMock<MockRemoteSuggestionsProvider>* underlying_provider_;
-  std::unique_ptr<SchedulingRemoteSuggestionsProvider> scheduling_provider_;
+  std::unique_ptr<MockRemoteSuggestionsProvider> provider_;
+  std::unique_ptr<RemoteSuggestionsSchedulerImpl> scheduler_;
   base::SimpleTestClock* test_clock_;
 
-  void ActivateUnderlyingProvider() {
+  void ActivateProvider() {
     SetEulaAcceptedPref();
-    scheduling_provider_->OnProviderActivated();
+    scheduler_->OnProviderActivated();
   }
 
-  void InactivateUnderlyingProvider() {
-    scheduling_provider_->OnProviderDeactivated();
-  }
+  void DeactivateProvider() { scheduler_->OnProviderDeactivated(); }
 
  private:
   test::RemoteSuggestionsTestUtils utils_;
   UserClassifier user_classifier_;
   TestingPrefServiceSimple local_state_;
 
-  DISALLOW_COPY_AND_ASSIGN(SchedulingRemoteSuggestionsProviderTest);
+  DISALLOW_COPY_AND_ASSIGN(RemoteSuggestionsSchedulerImplTest);
 };
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
-       ShouldIgnoreSignalsWhenNotEnabled) {
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
-  scheduling_provider_->OnNTPOpened();
-  scheduling_provider_->OnBrowserForegrounded();
-  scheduling_provider_->OnBrowserColdStart();
+TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldIgnoreSignalsWhenNotEnabled) {
+  scheduler_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnNTPOpened();
+  scheduler_->OnBrowserForegrounded();
+  scheduler_->OnBrowserColdStart();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldIgnoreEulaStateOnPlatformsWhereNotAvaiable) {
   // Only run this tests on platforms that don't support Eula.
   if (IsEulaNotifierAvailable()) {
     return;
   }
 
   // Activating the provider should schedule the persistent background fetches.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  scheduling_provider_->OnProviderActivated();
+  scheduler_->OnProviderActivated();
 
   // Verify fetches get triggered.
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
+  scheduler_->OnPersistentSchedulerWakeUp();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldIgnoreSignalsWhenEulaNotAccepted) {
   // Only run this tests on platforms supporting Eula.
   if (!IsEulaNotifierAvailable()) {
     return;
   }
   // Activating the provider should schedule the persistent background fetches.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  scheduling_provider_->OnProviderActivated();
+  scheduler_->OnProviderActivated();
 
   // All signals are ignored because of Eula not being accepted.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
-  scheduling_provider_->OnNTPOpened();
-  scheduling_provider_->OnBrowserForegrounded();
-  scheduling_provider_->OnBrowserColdStart();
+  scheduler_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnNTPOpened();
+  scheduler_->OnBrowserForegrounded();
+  scheduler_->OnBrowserColdStart();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
-       ShouldFetchWhenEulaGetsAccepted) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldFetchWhenEulaGetsAccepted) {
   // Only run this tests on platforms supporting Eula.
   if (!IsEulaNotifierAvailable()) {
     return;
   }
   // Activating the provider should schedule the persistent background fetches.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  scheduling_provider_->OnProviderActivated();
+  scheduler_->OnProviderActivated();
 
   // Make one (ignored) call to make sure we are interested in eula state.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
 
   // Accepting Eula afterwards results in a background fetch.
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
   SetEulaAcceptedPref();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldIgnoreSignalsWhenDisabledByParam) {
   // First set an empty list of allowed trigger types.
   SetVariationParameter("scheduler_trigger_types", "-");
   ResetProvider();
 
   // Then enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
-  scheduling_provider_->OnNTPOpened();
-  scheduling_provider_->OnBrowserForegrounded();
-  scheduling_provider_->OnBrowserColdStart();
+  scheduler_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnNTPOpened();
+  scheduler_->OnBrowserForegrounded();
+  scheduler_->OnBrowserColdStart();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldHandleEmptyParamForTriggerTypes) {
   // First set an empty param for allowed trigger types -> should result in the
   // default list.
   SetVariationParameter("scheduler_trigger_types", "");
   ResetProvider();
 
   // Then enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // For instance, persistent scheduler wake up should be enabled by default.
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
+  scheduler_->OnPersistentSchedulerWakeUp();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldHandleIncorrentParamForTriggerTypes) {
   // First set an invalid list of allowed trigger types.
   SetVariationParameter("scheduler_trigger_types", "ntp_opened,foo;");
   ResetProvider();
 
   // Then enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // For instance, persistent scheduler wake up should be enabled by default.
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
+  scheduler_->OnPersistentSchedulerWakeUp();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldFetchOnPersistentSchedulerWakeUp) {
   // First set only this type to be allowed.
   SetVariationParameter("scheduler_trigger_types",
                         "persistent_scheduler_wake_up");
   ResetProvider();
 
   // Then enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
+  scheduler_->OnPersistentSchedulerWakeUp();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldFetchOnPersistentSchedulerWakeUpRepeated) {
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
   {
     InSequence s;
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_))
         .WillOnce(SaveArg<0>(&signal_fetch_done));
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_));
   }
   // First enable the scheduler -- calling Schedule() for the first time.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
   // Make the first persistent fetch successful -- calling Schedule() again.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
   signal_fetch_done.Run(Status::Success());
   // Make the second fetch.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldNotTriggerBackgroundFetchIfAlreadyInProgess) {
   {
     InSequence s;
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_));
     // RefetchInTheBackground is not called after the second trigger.
   }
   // First enable the scheduler -- calling Schedule() for the first time.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
   // Make the first persistent fetch never finish.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
   // Make the second fetch.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldFetchOnNTPOpenedForTheFirstTime) {
   // First set only this type to be allowed.
   SetVariationParameter("scheduler_trigger_types", "ntp_opened");
   ResetProvider();
 
   // Then enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
-  scheduling_provider_->OnNTPOpened();
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
+  scheduler_->OnNTPOpened();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldFetchOnBrowserForegroundedForTheFirstTime) {
   // First set only this type to be allowed.
   SetVariationParameter("scheduler_trigger_types", "browser_foregrounded");
   ResetProvider();
 
   // Then enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
-  scheduling_provider_->OnBrowserForegrounded();
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
+  scheduler_->OnBrowserForegrounded();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldFetchOnBrowserColdStartForTheFirstTime) {
   // First set only this type to be allowed.
   SetVariationParameter("scheduler_trigger_types", "browser_cold_start");
   ResetProvider();
 
   // Then enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
-  scheduling_provider_->OnBrowserColdStart();
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
+  scheduler_->OnBrowserColdStart();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldNotFetchOnNTPOpenedAfterSuccessfulSoftFetch) {
   // First enable the scheduler; the second Schedule is called after the
   // successful fetch.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(2);
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // Make the first soft fetch successful.
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .WillOnce(SaveArg<0>(&signal_fetch_done));
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
   signal_fetch_done.Run(Status::Success());
   // The second call is ignored if it happens right after the first one.
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldNotFetchOnNTPOpenedAfterSuccessfulPersistentFetch) {
   // First enable the scheduler; the second Schedule is called after the
   // successful fetch.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(2);
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // Make the first persistent fetch successful.
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .WillOnce(SaveArg<0>(&signal_fetch_done));
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
   signal_fetch_done.Run(Status::Success());
   // The second call is ignored if it happens right after the first one.
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldNotFetchOnNTPOpenedAfterFailedSoftFetch) {
   // First enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // Make the first soft fetch failed.
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .WillOnce(SaveArg<0>(&signal_fetch_done));
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
   signal_fetch_done.Run(Status(StatusCode::PERMANENT_ERROR, ""));
 
   // The second call is ignored if it happens right after the first one.
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldNotFetchOnNTPOpenedAfterFailedPersistentFetch) {
   // First enable the scheduler.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // Make the first persistent fetch failed.
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .WillOnce(SaveArg<0>(&signal_fetch_done));
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
   signal_fetch_done.Run(Status(StatusCode::PERMANENT_ERROR, ""));
 
   // The second call is ignored if it happens right after the first one.
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldFetchAgainOnBrowserForgroundLaterAgain) {
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
   {
     InSequence s;
     // Initial scheduling after being enabled.
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     // The first call to NTPOpened results in a fetch.
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_))
         .WillOnce(SaveArg<0>(&signal_fetch_done));
     // Rescheduling after a succesful fetch.
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     // The second call to NTPOpened 2hrs later again results in a fetch.
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_));
   }
 
   // First enable the scheduler.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
   // Make the first soft fetch successful.
-  scheduling_provider_->OnBrowserForegrounded();
+  scheduler_->OnBrowserForegrounded();
   signal_fetch_done.Run(Status::Success());
   // Open NTP again after 2hrs.
   test_clock_->Advance(base::TimeDelta::FromHours(2));
-  scheduling_provider_->OnBrowserForegrounded();
+  scheduler_->OnBrowserForegrounded();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldRescheduleOnRescheduleFetching) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  scheduling_provider_->RescheduleFetching();
+  scheduler_->RescheduleFetching();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest, ShouldScheduleOnActivation) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldScheduleOnActivation) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldUnscheduleOnLaterInactivation) {
   {
     InSequence s;
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     EXPECT_CALL(persistent_scheduler_, Unschedule());
   }
-  ActivateUnderlyingProvider();
-  InactivateUnderlyingProvider();
+  ActivateProvider();
+  DeactivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
-       ShouldScheduleOnLaterActivation) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldScheduleOnLaterActivation) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
   // There is no schedule yet, so inactivation does not trigger unschedule.
-  InactivateUnderlyingProvider();
-  ActivateUnderlyingProvider();
+  DeactivateProvider();
+  ActivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldRescheduleAfterSuccessfulFetch) {
   // First reschedule on becoming active.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(2);
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .WillOnce(SaveArg<0>(&signal_fetch_done));
 
   // Trigger a fetch.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
   // Second reschedule after a successful fetch.
   signal_fetch_done.Run(Status::Success());
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldNotRescheduleAfterFailedFetch) {
   // Only reschedule on becoming active.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .WillOnce(SaveArg<0>(&signal_fetch_done));
 
   // Trigger a fetch.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
   // No furter reschedule after a failure.
   signal_fetch_done.Run(Status(StatusCode::PERMANENT_ERROR, ""));
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest, ShouldScheduleOnlyOnce) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldScheduleOnlyOnce) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
   // No further call to Schedule on a second status callback.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest, ShouldUnscheduleOnlyOnce) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldUnscheduleOnlyOnce) {
   {
     InSequence s;
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     EXPECT_CALL(persistent_scheduler_, Unschedule());
   }
   // First schedule so that later we really unschedule.
-  ActivateUnderlyingProvider();
-  InactivateUnderlyingProvider();
+  ActivateProvider();
+  DeactivateProvider();
   // No further call to Unschedule on second status callback.
-  InactivateUnderlyingProvider();
+  DeactivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
-       ReschedulesWhenWifiParamChanges) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, ReschedulesWhenWifiParamChanges) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(2);
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
   // null. Change the wifi interval for this class.
   SetVariationParameter("fetching_interval_hours-wifi-active_ntp_user", "1.5");
 
   // Schedule() should get called for the second time after params have changed.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ReschedulesWhenFallbackParamChanges) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(2);
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
   // null. Change the fallback interval for this class.
   SetVariationParameter("fetching_interval_hours-fallback-active_ntp_user",
                         "1.5");
 
   // Schedule() should get called for the second time after params have changed.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ReschedulesWhenOnUsageEventParamChanges) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(2);
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
   // null. Change the on usage interval for this class.
   SetVariationParameter("soft_fetching_interval_hours-active-active_ntp_user",
                         "1.5");
 
   // Schedule() should get called for the second time after params have changed.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ReschedulesWhenOnNtpOpenedParamChanges) {
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(2);
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
   // null. Change the fallback interval for this class.
   SetVariationParameter("soft_on_ntp_opened_interval_hours-active_ntp_user",
                         "1.5");
 
   // Schedule() should get called for the second time after params have changed.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
-       FetchIntervalForNtpOpenedTrigger) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, FetchIntervalForNtpOpenedTrigger) {
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
   {
     InSequence s;
     // Initial scheduling after being enabled.
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     // The first call to NTPOpened results in a fetch.
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_))
         .WillOnce(SaveArg<0>(&signal_fetch_done));
     // Rescheduling after a succesful fetch.
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     // The third call to NTPOpened 35min later again results in a fetch.
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_));
   }
 
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
   signal_fetch_done.Run(Status::Success());
 
   // UserClassifier defaults to UserClass::ACTIVE_NTP_USER which uses a 2h time
   // interval by default for soft backgroudn fetches on ntp open events.
 
   // Open NTP again after 20min. This time no fetch is executed.
   test_clock_->Advance(base::TimeDelta::FromMinutes(20));
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 
   // Open NTP again after 101min (121min since first opened). Since the default
   // time interval has passed refetch again.
   test_clock_->Advance(base::TimeDelta::FromMinutes(101));
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        OverrideFetchIntervalForNtpOpenedTrigger) {
   // UserClassifier defaults to UserClass::ACTIVE_NTP_USER if PrefService is
   // null. Change the on usage interval for this class from 2h to 30min.
   SetVariationParameter("soft_on_ntp_opened_interval_hours-active_ntp_user",
                         "0.5");
 
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
   {
     InSequence s;
     // Initial scheduling after being enabled.
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     // The first call to NTPOpened results in a fetch.
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_))
         .WillOnce(SaveArg<0>(&signal_fetch_done));
     // Rescheduling after a succesful fetch.
     EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
     // The third call to NTPOpened 35min later again results in a fetch.
-    EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
+    EXPECT_CALL(*provider_, RefetchInTheBackground(_));
   }
 
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
   signal_fetch_done.Run(Status::Success());
 
   // Open NTP again after 20min. No fetch request is issues since the 30 min
   // time interval has not passed yet.
   test_clock_->Advance(base::TimeDelta::FromMinutes(20));
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 
   // Open NTP again after 15min (35min since first opened)
   test_clock_->Advance(base::TimeDelta::FromMinutes(15));
-  scheduling_provider_->OnNTPOpened();
+  scheduler_->OnNTPOpened();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldBlockFetchingForSomeTimeAfterHistoryCleared) {
   // First enable the scheduler -- this will trigger the persistent scheduling.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
   // Clear the history.
-  scheduling_provider_->OnHistoryCleared();
+  scheduler_->OnHistoryCleared();
 
   // A trigger after 15 minutes is ignored.
   test_clock_->Advance(base::TimeDelta::FromMinutes(15));
-  scheduling_provider_->OnBrowserForegrounded();
+  scheduler_->OnBrowserForegrounded();
 
   // A trigger after another 16 minutes is performed (more than 30m after
   // clearing the history).
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_));
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_));
   test_clock_->Advance(base::TimeDelta::FromMinutes(16));
-  scheduling_provider_->OnBrowserForegrounded();
+  scheduler_->OnBrowserForegrounded();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldImmediatelyFetchAfterSuggestionsCleared) {
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
 
   // First enable the scheduler -- this will trigger the persistent scheduling.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // The first trigger results in a fetch.
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .WillOnce(SaveArg<0>(&signal_fetch_done));
-  scheduling_provider_->OnBrowserForegrounded();
+  scheduler_->OnBrowserForegrounded();
   // Make the fetch successful -- this results in rescheduling.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _));
   signal_fetch_done.Run(Status::Success());
 
   // Clear the suggestions - results in an immediate fetch.
-  EXPECT_CALL(*underlying_provider_, ReloadSuggestions());
-  scheduling_provider_->OnSuggestionsCleared();
+  EXPECT_CALL(*provider_, ReloadSuggestions());
+  scheduler_->OnSuggestionsCleared();
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
-       ShouldThrottleInteractiveRequests) {
+TEST_F(RemoteSuggestionsSchedulerImplTest, ShouldThrottleInteractiveRequests) {
   // Change the quota for interactive requests ("active NTP user" is the default
   // class in tests).
   SetVariationParameter("interactive_quota_SuggestionFetcherActiveNTPUser",
                         "10");
   ResetProvider();
 
-  Category category = Category::FromKnownCategory(KnownCategories::ARTICLES);
-  std::set<std::string> known_suggestions;
-
-  // Both Fetch(..) and ReloadSuggestions() consume the same quota. As long as
-  // the quota suffices, the call gets through.
-  EXPECT_CALL(*underlying_provider_, ReloadSuggestions()).Times(5);
-  for (int x = 0; x < 5; ++x) {
-    scheduling_provider_->ReloadSuggestions();
+  for (int x = 0; x < 10; ++x) {
+    EXPECT_THAT(scheduler_->AcquireQuotaForInteractiveFetch(), Eq(true));
   }
 
-  // Expect underlying provider being called and store the callback to inform
-  // scheduling provider.
-  FetchDoneCallback signal_fetch_done_from_underlying_provider;
-  EXPECT_CALL(*underlying_provider_, Fetch(_, _, _))
-      .Times(5)
-      .WillRepeatedly(SaveArg<2>(&signal_fetch_done_from_underlying_provider));
-  // Expect scheduling provider to pass the information through.
-  MockFunction<void(Status status_code,
-                    const std::vector<ContentSuggestion>& suggestions)>
-      fetch_done_from_scheduling_provider;
-  EXPECT_CALL(fetch_done_from_scheduling_provider,
-              Call(Field(&Status::code, StatusCode::SUCCESS), _))
-      .Times(5);
-  // Scheduling is not activated, each successful fetch results in Unschedule().
-  EXPECT_CALL(persistent_scheduler_, Unschedule()).Times(5);
-  for (int x = 0; x < 5; ++x) {
-    scheduling_provider_->Fetch(
-        category, known_suggestions,
-        base::Bind(&SchedulingRemoteSuggestionsProviderTest::FetchDoneWrapper,
-                   base::Unretained(this),
-                   &fetch_done_from_scheduling_provider));
-    // Inform scheduling provider the fetc is successful (with no suggestions).
-    signal_fetch_done_from_underlying_provider.Run(
-        Status::Success(), std::vector<ContentSuggestion>{});
-  }
-
-  // When the quota expires, it is blocked by the scheduling provider, directly
-  // calling the callback.
-  EXPECT_CALL(fetch_done_from_scheduling_provider,
-              Call(Field(&Status::code, StatusCode::TEMPORARY_ERROR), _));
-  scheduling_provider_->ReloadSuggestions();
-  scheduling_provider_->Fetch(
-      category, known_suggestions,
-      base::Bind(&SchedulingRemoteSuggestionsProviderTest::FetchDoneWrapper,
-                 base::Unretained(this), &fetch_done_from_scheduling_provider));
+  // Now the quota is over.
+  EXPECT_THAT(scheduler_->AcquireQuotaForInteractiveFetch(), Eq(false));
 }
 
-TEST_F(SchedulingRemoteSuggestionsProviderTest,
+TEST_F(RemoteSuggestionsSchedulerImplTest,
        ShouldThrottleNonInteractiveRequests) {
   // Change the quota for interactive requests ("active NTP user" is the default
   // class in tests).
   SetVariationParameter("quota_SuggestionFetcherActiveNTPUser", "5");
   ResetProvider();
 
   // One scheduling on start, 5 times after successful fetches.
   EXPECT_CALL(persistent_scheduler_, Schedule(_, _)).Times(6);
 
   // First enable the scheduler -- this will trigger the persistent scheduling.
-  ActivateUnderlyingProvider();
+  ActivateProvider();
 
   // As long as the quota suffices, the call gets through.
   RemoteSuggestionsProvider::FetchStatusCallback signal_fetch_done;
-  EXPECT_CALL(*underlying_provider_, RefetchInTheBackground(_))
+  EXPECT_CALL(*provider_, RefetchInTheBackground(_))
       .Times(5)
       .WillRepeatedly(SaveArg<0>(&signal_fetch_done));
   for (int x = 0; x < 5; ++x) {
-    scheduling_provider_->OnPersistentSchedulerWakeUp();
+    scheduler_->OnPersistentSchedulerWakeUp();
     signal_fetch_done.Run(Status::Success());
   }
 
   // For the 6th time, it is blocked by the scheduling provider.
-  scheduling_provider_->OnPersistentSchedulerWakeUp();
+  scheduler_->OnPersistentSchedulerWakeUp();
 }
 
 }  // namespace ntp_snippets