[Remote suggestions] Refactor the scheduler

components/ntp_snippets/remote/remote_suggestions_scheduler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_SCHEDULER_H_
 #define COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_SCHEDULER_H_
 
 #include "base/macros.h"
+#include "components/ntp_snippets/remote/remote_suggestions_provider.h"

[Marc Treib, 2017/03/27 11:31:00]

I think this can just be forward declared.

[jkrcal, 2017/03/27 14:09:31]

Done.

 
 namespace ntp_snippets {
 
 // Interface for informing the scheduler.
 class RemoteSuggestionsScheduler {
  public:
   // Internal triggers to consider fetching content suggestions.
 
   // Called whenever the remote suggestions provider becomes active (on startup,
   // or later on).
   virtual void OnProviderActivated() = 0;
 
   // Called whenever the remote suggestions provider becomes inactive (on
   // startup, or later on).
   virtual void OnProviderDeactivated() = 0;
 
   // Called whenever the remote suggestions provider clears all suggestions.
   virtual void OnSuggestionsCleared() = 0;
 
   // Called whenever the remote suggestions provider clears all suggestions
   // because history gets cleared (and we must not show them any more).
   virtual void OnHistoryCleared() = 0;
 
+  // Returns true if quota is available for another request.
+  virtual bool AcquireQuotaForInteractiveFetch() = 0;
+
+  // Called whenever the remote suggestions provider finishes an interactive
+  // fetch (with provided |fetch_status|).
+  virtual void OnInteractiveFetchFinished(Status fetch_status) = 0;

[Marc Treib, 2017/03/27 11:31:00]

#include for Status?

[jkrcal, 2017/03/27 14:09:31]

I forward-declared it.

+
   // External triggers to consider fetching content suggestions.
 
   // Called whenever chrome is started warm or the user switches to Chrome.
   virtual void OnBrowserForegrounded() = 0;
 
   // Called whenever chrome is cold started.
   // To keep start ups fast, defer any work possible.
   virtual void OnBrowserColdStart() = 0;
 
   // Called whenever a new NTP is opened. This may be called on cold starts.
   // So to keep start ups fast, defer heavy work for cold starts.
   virtual void OnNTPOpened() = 0;
 
   // Fetch content suggestions.
   virtual void OnPersistentSchedulerWakeUp() = 0;
 
   // Force rescheduling of fetching.
   virtual void RescheduleFetching() = 0;
+
+  void set_provider(RemoteSuggestionsProvider* provider) {
+    provider_ = provider;
+  };
+
+ protected:
+  // Interface for doing all the actual work (apart from scheduling).
+  RemoteSuggestionsProvider* provider_;

[Marc Treib, 2017/03/27 11:31:00]

Maybe move this out of the interface and into the impl, so that this stays an
actual interface?
If you keep it here, then you also have to add a ctor to initialize it. Also I'd
prefer to make it private and add an accessor.

[jkrcal, 2017/03/27 14:09:31]

Moved out.

 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_REMOTE_REMOTE_SUGGESTIONS_SCHEDULER_H_