Support for parsing external file references in a glTF resource.

chrome/browser/android/vr_shell/gltf_parser_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/vr_shell/gltf_parser.h"
 
 #include <memory>
 
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/json/json_file_value_serializer.h"
 #include "base/memory/ptr_util.h"
 #include "base/path_service.h"
 #include "base/values.h"
 #include "chrome/browser/android/vr_shell/test/paths.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace vr_shell {
 
-TEST(GltfParser, Parse) {
-  test::RegisterPathProvider();
-  base::FilePath gltf_path;
-  PathService::Get(test::DIR_TEST_DATA, &gltf_path);
-  gltf_path = gltf_path.Append("sample_inline.gltf");
+class GltfParserTest : public testing::Test {
+ protected:
+  void SetUp() override {
+    test::RegisterPathProvider();
+    PathService::Get(test::DIR_TEST_DATA, &data_dir_);
+  }
+
+  base::FilePath data_dir_;
+};
+
+TEST_F(GltfParserTest, Parse) {
+  auto gltf_path = data_dir_.Append("sample_inline.gltf");
 
   int error_code;
   std::string error_msg;
   JSONFileValueDeserializer json_deserializer(gltf_path);
   auto asset_value = json_deserializer.Deserialize(&error_code, &error_msg);
   EXPECT_NE(nullptr, asset_value);
   base::DictionaryValue* asset;
   EXPECT_TRUE(asset_value->GetAsDictionary(&asset));
 
   GltfParser parser;
@@ skipping 50 matching lines @@
 
   const gltf::Scene* scene = gltf_model->GetScene(0);
   EXPECT_NE(nullptr, scene);
   EXPECT_EQ(nullptr, gltf_model->GetNode(2));
   EXPECT_EQ(1u, scene->nodes.size());
   EXPECT_EQ(node_1, scene->nodes[0]);
 
   EXPECT_EQ(scene, gltf_model->GetMainScene());
 }
 
+TEST_F(GltfParserTest, ParseExternal) {
+  auto gltf_path = data_dir_.Append("sample_external.gltf");
+
+  GltfParser parser;
+  auto gltf_model = parser.Parse(gltf_path);
+  EXPECT_NE(nullptr, gltf_model);
+  const gltf::Buffer* buffer = gltf_model->GetBuffer(0);
+  EXPECT_NE(nullptr, buffer);
+  EXPECT_EQ("HELLO WORLD!", *buffer);
+  EXPECT_EQ(12u, buffer->length());
+}
+
 }  // namespace vr_shell

[cjgrant, 2017/03/24 15:11:54]

Could you add at least one test that expects a failure if your model is broken? 
Can be any of the cases that cause a failure.

[acondor_, 2017/03/24 18:00:55]

Done.