Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2774623004: Fix for dcall on callable class (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for dcall on callable class (Note, regenerated files aren't being uploaded) Fixes #29148 R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/053d2ce14fafecb677589eec8fe84873e81e3aec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language_strong/callable_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vsm
3 years, 9 months ago (2017-03-23 19:53:30 UTC) #3
Leaf
lgtm
3 years, 9 months ago (2017-03-23 20:13:24 UTC) #4
vsm
Committed patchset #1 (id:1) manually as 053d2ce14fafecb677589eec8fe84873e81e3aec (presubmit successful).
3 years, 9 months ago (2017-03-23 20:15:10 UTC) #6
Jennifer Messerly
3 years, 9 months ago (2017-03-23 21:26:20 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698