Source/core/html/forms/CheckboxInputType.h - Issue 27746003: Have InputType factories take an HTMLInputElement reference in parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/CheckboxInputType.h

Issue 27746003: Have InputType factories take an HTMLInputElement reference in parameter (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/CheckboxInputType.h

diff --git a/Source/core/html/forms/CheckboxInputType.h b/Source/core/html/forms/CheckboxInputType.h

index 3cef9b921cc404394978b439d1b0b93cee3f722e..9299018f6b5c8c7ecab1f512f3a3cad43d8d43b9 100644

--- a/Source/core/html/forms/CheckboxInputType.h

+++ b/Source/core/html/forms/CheckboxInputType.h

@@ -37,10 +37,10 @@ namespace WebCore {

class CheckboxInputType : public BaseCheckableInputType {

public:

- static PassRefPtr<InputType> create(HTMLInputElement*);

+ static PassRefPtr<InputType> create(HTMLInputElement&);

private:

- CheckboxInputType(HTMLInputElement* element) : BaseCheckableInputType(element) { }

+ CheckboxInputType(HTMLInputElement& element) : BaseCheckableInputType(element) { }

virtual const AtomicString& formControlType() const OVERRIDE;

virtual bool valueMissing(const String&) const OVERRIDE;

virtual String valueMissingText() const OVERRIDE;