Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 27746003: Have InputType factories take an HTMLInputElement reference in parameter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/forms/BaseButtonInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index 7e0c95f513de5d75f3e0fd8f8a3c0d0f79bc6699..7eab43ad5506bd99faa1fbf002dd756541e19caf 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -116,7 +116,7 @@ HTMLInputElement::HTMLInputElement(const QualifiedName& tagName, Document& docum
, m_wasModifiedByUser(false)
, m_canReceiveDroppedFiles(false)
, m_hasTouchEventHandler(false)
- , m_inputType(InputType::createText(this))
+ , m_inputType(InputType::createText(*this))
, m_inputTypeView(m_inputType)
{
ASSERT(hasTagName(inputTag) || hasTagName(isindexTag));
@@ -149,7 +149,7 @@ void HTMLInputElement::didAddShadowRoot(ShadowRoot& root)
{
if (!root.isOldestAuthorShadowRoot())
return;
- m_inputTypeView = InputTypeView::create(this);
+ m_inputTypeView = InputTypeView::create(*this);
}
HTMLInputElement::~HTMLInputElement()
@@ -411,7 +411,7 @@ void HTMLInputElement::updateType()
return;
}
- RefPtr<InputType> newType = InputType::create(this, newTypeName);
+ RefPtr<InputType> newType = InputType::create(*this, newTypeName);
removeFromRadioButtonGroup();
bool didStoreValue = m_inputType->storesValueSeparateFromAttribute();
@@ -425,7 +425,7 @@ void HTMLInputElement::updateType()
m_inputType = newType.release();
if (hasAuthorShadowRoot())
- m_inputTypeView = InputTypeView::create(this);
+ m_inputTypeView = InputTypeView::create(*this);
else
m_inputTypeView = m_inputType;
m_inputType->createShadowSubtree();
« no previous file with comments | « no previous file | Source/core/html/forms/BaseButtonInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698