Have InputType factories take an HTMLInputElement reference in parameter

Source/core/html/forms/SearchInputType.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "core/html/forms/InputTypeNames.h"
 #include "core/html/shadow/ShadowElementNames.h"
 #include "core/html/shadow/TextControlInnerElements.h"
 #include "core/rendering/RenderSearchField.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
-inline SearchInputType::SearchInputType(HTMLInputElement* element)
+inline SearchInputType::SearchInputType(HTMLInputElement& element)
     : BaseTextInputType(element)
     , m_searchEventTimer(this, &SearchInputType::searchEventTimerFired)
 {
 }
 
-PassRefPtr<InputType> SearchInputType::create(HTMLInputElement* element)
+PassRefPtr<InputType> SearchInputType::create(HTMLInputElement& element)
 {
     return adoptRef(new SearchInputType(element));
 }
 
 void SearchInputType::countUsage()
 {
     observeFeatureIfVisible(UseCounter::InputTypeSearch);
 }
 
 RenderObject* SearchInputType::createRenderer(RenderStyle*) const
 {
-    return new RenderSearchField(element());
+    return new RenderSearchField(&element());
 }
 
 const AtomicString& SearchInputType::formControlType() const
 {
     return InputTypeNames::search();
 }
 
 bool SearchInputType::shouldRespectSpeechAttribute()
 {
     return true;
 }
 
 bool SearchInputType::isSearchField() const
 {
     return true;
 }
 
 bool SearchInputType::needsContainer() const
 {
     return true;
 }
 
 void SearchInputType::createShadowSubtree()
 {
     TextFieldInputType::createShadowSubtree();
     Element* container = containerElement();
-    Element* viewPort = element()->userAgentShadowRoot()->getElementById(ShadowElementNames::editingViewPort());
+    Element* viewPort = element().userAgentShadowRoot()->getElementById(ShadowElementNames::editingViewPort());
     ASSERT(container);
     ASSERT(viewPort);
 
-    container->insertBefore(SearchFieldDecorationElement::create(element()->document()), viewPort);
-    container->insertBefore(SearchFieldCancelButtonElement::create(element()->document()), viewPort->nextSibling());
+    container->insertBefore(SearchFieldDecorationElement::create(element().document()), viewPort);
+    container->insertBefore(SearchFieldCancelButtonElement::create(element().document()), viewPort->nextSibling());
 }
 
 void SearchInputType::handleKeydownEvent(KeyboardEvent* event)
 {
-    if (element()->isDisabledOrReadOnly()) {
+    if (element().isDisabledOrReadOnly()) {
         TextFieldInputType::handleKeydownEvent(event);
         return;
     }
 
     const String& key = event->keyIdentifier();
     if (key == "U+001B") {
-        RefPtr<HTMLInputElement> input = element();
+        RefPtr<HTMLInputElement> input(element());
         input->setValueForUser("");
         input->onSearch();
         event->setDefaultHandled();
         return;
     }
     TextFieldInputType::handleKeydownEvent(event);
 }
 
 void SearchInputType::startSearchEventTimer()
 {
-    ASSERT(element()->renderer());
-    unsigned length = element()->innerTextValue().length();
+    ASSERT(element().renderer());
+    unsigned length = element().innerTextValue().length();
 
     if (!length) {
         stopSearchEventTimer();
-        element()->onSearch();
+        element().onSearch();
         return;
     }
 
     // After typing the first key, we wait 0.5 seconds.
     // After the second key, 0.4 seconds, then 0.3, then 0.2 from then on.
     m_searchEventTimer.startOneShot(max(0.2, 0.6 - 0.1 * length));
 }
 
 void SearchInputType::stopSearchEventTimer()
 {
     m_searchEventTimer.stop();
 }
 
 void SearchInputType::searchEventTimerFired(Timer<SearchInputType>*)
 {
-    element()->onSearch();
+    element().onSearch();
 }
 
 bool SearchInputType::searchEventsShouldBeDispatched() const
 {
-    return element()->hasAttribute(incrementalAttr);
+    return element().hasAttribute(incrementalAttr);
 }
 
 void SearchInputType::didSetValueByUserEdit(ValueChangeState state)
 {
     updateCancelButtonVisibility();
 
     // If the incremental attribute is set, then dispatch the search event
     if (searchEventsShouldBeDispatched())
         startSearchEventTimer();
 
     TextFieldInputType::didSetValueByUserEdit(state);
 }
 
 void SearchInputType::updateInnerTextValue()
 {
     BaseTextInputType::updateInnerTextValue();
     updateCancelButtonVisibility();
 }
 
 void SearchInputType::updateCancelButtonVisibility()
 {
-    Element* button = element()->userAgentShadowRoot()->getElementById(ShadowElementNames::clearButton());
+    Element* button = element().userAgentShadowRoot()->getElementById(ShadowElementNames::clearButton());
     if (!button)
         return;
-    if (element()->value().isEmpty())
+    if (element().value().isEmpty())
         button->setInlineStyleProperty(CSSPropertyVisibility, CSSValueHidden);
     else
         button->removeInlineStyleProperty(CSSPropertyVisibility);
 }
 
 bool SearchInputType::supportsInputModeAttribute() const
 {
     return true;
 }
 
 } // namespace WebCore