ui: Reduce logging in ui::ClientNativePixmapDmaBuf.

ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc

Index: ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc
diff --git a/ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc b/ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc
index c7bdeb3f467ff60fb970bbe0212d767845cbd7a9..b1d23466ed832b8ce646a37f292db46b4e3fcb7b 100644
--- a/ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc
+++ b/ui/ozone/platform/drm/common/client_native_pixmap_dmabuf.cc
@@ -47,16 +47,22 @@ void PrimeSyncStart(int dmabuf_fd) {
   struct local_dma_buf_sync sync_start = {0};
 
   sync_start.flags = LOCAL_DMA_BUF_SYNC_START | LOCAL_DMA_BUF_SYNC_RW;
-  if (drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_start))
-    PLOG(ERROR) << "Failed DMA_BUF_SYNC_START";
+#if DCHECK_IS_ON()
+  int rv =
+#endif
+      drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_start);
+  DPLOG_IF(ERROR, rv) << "Failed DMA_BUF_SYNC_START";

[dnicoara, 2017/03/24 15:03:59]

Without the PLOG, can we tell if these are failing on consumer devices? 

Would it make sense to have it output this error at least once in release
builds? Perhaps a simple "static bool logged_once" here to simplify things?

[reveman, 2017/03/24 17:16:49]

I did that in previous patch but we thought this was better for now. We
currently have drivers not implementing this but that's fine as they return
uncached memory from mmap so I'd rather not have people worry about these
messages in the log until we've updated the drivers to have proper no op
implementations of this ioctl instead. 

 }
 
 void PrimeSyncEnd(int dmabuf_fd) {
   struct local_dma_buf_sync sync_end = {0};
 
   sync_end.flags = LOCAL_DMA_BUF_SYNC_END | LOCAL_DMA_BUF_SYNC_RW;
-  if (drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_end))
-    PLOG(ERROR) << "Failed DMA_BUF_SYNC_END";
+#if DCHECK_IS_ON()

[Daniele Castagna, 2017/03/24 01:54:08]

It's ugly, but if it's the standard way of doing it I'm ok with it.

+  int rv =
+#endif
+      drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_end);
+  DPLOG_IF(ERROR, rv) << "Failed DMA_BUF_SYNC_END";
 }
 
 }  // namespace