ui: Reduce logging in ui::ClientNativePixmapDmaBuf.

ui/gfx/linux/client_native_pixmap_dmabuf.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/linux/client_native_pixmap_dmabuf.h"
 
 #include <fcntl.h>
 #include <linux/version.h>
 #include <stddef.h>
 #include <sys/mman.h>
@@ skipping 29 matching lines @@
 #endif
 
 namespace gfx {
 
 namespace {
 
 void PrimeSyncStart(int dmabuf_fd) {
   struct local_dma_buf_sync sync_start = {0};
 
   sync_start.flags = LOCAL_DMA_BUF_SYNC_START | LOCAL_DMA_BUF_SYNC_RW;
-  if (drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_start))
-    PLOG(ERROR) << "Failed DMA_BUF_SYNC_START";
+#if DCHECK_IS_ON()
+  int rv =
+#endif
+      drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_start);

[marcheu, 2017/03/28 01:07:26]

I don't think drmIoctl is meant to be used for non-drm ioctls. In other words,
you should use ioctl() here and wrap your own error handler around it.

+  DPLOG_IF(ERROR, rv) << "Failed DMA_BUF_SYNC_START";
 }
 
 void PrimeSyncEnd(int dmabuf_fd) {
   struct local_dma_buf_sync sync_end = {0};
 
   sync_end.flags = LOCAL_DMA_BUF_SYNC_END | LOCAL_DMA_BUF_SYNC_RW;
-  if (drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_end))
-    PLOG(ERROR) << "Failed DMA_BUF_SYNC_END";
+#if DCHECK_IS_ON()
+  int rv =
+#endif
+      drmIoctl(dmabuf_fd, LOCAL_DMA_BUF_IOCTL_SYNC, &sync_end);
+  DPLOG_IF(ERROR, rv) << "Failed DMA_BUF_SYNC_END";
 }
 
 }  // namespace
 
 // static
 std::unique_ptr<gfx::ClientNativePixmap>
 ClientNativePixmapDmaBuf::ImportFromDmabuf(
     const gfx::NativePixmapHandle& handle,
     const gfx::Size& size) {
   return base::WrapUnique(new ClientNativePixmapDmaBuf(handle, size));
@@ skipping 71 matching lines @@
   uint8_t* address = reinterpret_cast<uint8_t*>(data_);
   return address + pixmap_handle_.planes[plane].offset;
 }
 
 int ClientNativePixmapDmaBuf::GetStride(size_t plane) const {
   DCHECK_LT(plane, pixmap_handle_.planes.size());
   return pixmap_handle_.planes[plane].stride;
 }
 
 }  // namespace gfx