Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h

Issue 2774543003: Fix PerformanceNavigationTiming accessor behavior after document detach. (Closed)
Patch Set: sync Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h b/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
index 62f2f15c6a54b2884eeada9d80b4d9d939316d2e..4257c59cc0e6e64ffa71ba42ff1d72350aa5f5a5 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h
@@ -6,6 +6,7 @@
#define PerformanceNavigationTiming_h
#include "core/CoreExport.h"
+#include "core/dom/ContextLifecycleObserver.h"
#include "core/dom/DOMHighResTimeStamp.h"
#include "core/loader/FrameLoaderTypes.h"
#include "core/timing/PerformanceResourceTiming.h"
@@ -22,8 +23,10 @@ class ResourceTimingInfo;
class ResourceLoadTiming;
class CORE_EXPORT PerformanceNavigationTiming final
- : public PerformanceResourceTiming {
+ : public PerformanceResourceTiming,
+ public ContextClient {
DEFINE_WRAPPERTYPEINFO();
+ USING_GARBAGE_COLLECTED_MIXIN(PerformanceNavigationTiming);
friend class PerformanceNavigationTimingTest;
public:
@@ -79,8 +82,6 @@ class CORE_EXPORT PerformanceNavigationTiming final
double m_timeOrigin;
RefPtr<ResourceTimingInfo> m_resourceTimingInfo;
- // TODO(sunjian): Investigate why not using a Member instead.
- WeakMember<LocalFrame> m_frame;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698