third_party/WebKit/LayoutTests/external/wpt/navigation-timing/nav2_test_frame_removed.html - Issue 2774543003: Fix PerformanceNavigationTiming accessor behavior after document detach.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/navigation-timing/nav2_test_frame_removed.html

Issue 2774543003: Fix PerformanceNavigationTiming accessor behavior after document detach. (Closed)

Patch Set: addressed comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/navigation-timing/nav2_test_document_replaced.html ('k') | third_party/WebKit/Source/core/timing/PerformanceNavigationTiming.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta charset="utf-8" />

	5 <title>Navigation Timing 2 WPT</title>

	6 <link rel="author" title="Google" href="http://www.google.com/" />

	7 <link rel="help" href="http://www.w3.org/TR/navigation-timing/#sec-navig ation-timing-interface"/>

	8 <script src="/resources/testharness.js"></script>

	9 <script src="/resources/testharnessreport.js"></script>

	10 <script>

	11 function onload_test()

	12 { test(function() {

	13 var pnt = window.frames[0].performance.getEntriesByType("nav igation")[0];

	14 document.getElementById("frameContext").remove();

	15 assert_equals(pnt.type, "navigate");
	Nate Chapin 2017/03/27 23:52:20 By the way, is this behavior actually in the spec? By the way, is this behavior actually in the spec? If not, should it be? panicker 2017/03/28 00:21:27 This seems like the right default based on descrip Show quoted text On 2017/03/27 23:52:20, Nate Chapin wrote: > By the way, is this behavior actually in the spec? If not, should it be? This seems like the right default based on description of "navigate" here: https://www.w3.org/TR/navigation-timing-2/#dom-performancenavigationtiming-type "Navigation started by clicking on a link, or entering the URL in the user agent's address bar, or form submission, or initializing through a script operation other than the ones used by reload and back_forward as listed below." Let me know if you think it needs further clarification.
	16 });

	17 }

	18 </script>

	19 </head>

	20 <body>

	21 <h1>

	22 Description</h1>

	23 <p>

	24 This test validates that PerformanceNavigationTiming::type()'s defua lt value is navigate </p>

	25 <iframe id="frameContext" onload="onload_test();" src="resources/blank_p age_yellow_with_onunload.html" style="width: 250px; height: 250px;"></iframe>

	26 </body>

	27 </html>

OLD	NEW