Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2774523002: Make gen_snapshot quiet for the Fuchsia build. (Closed)

Created:
3 years, 9 months ago by rmacnak
Modified:
3 years, 9 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +0 lines, -5 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
rmacnak
https://codereview.chromium.org/2774523002/diff/1/runtime/bin/gen_snapshot.cc File runtime/bin/gen_snapshot.cc (left): https://codereview.chromium.org/2774523002/diff/1/runtime/bin/gen_snapshot.cc#oldcode1474 runtime/bin/gen_snapshot.cc:1474: vm_options.AddArgument("--print_snapshot_sizes"); These flags have since been passed explicitly by ...
3 years, 9 months ago (2017-03-23 00:46:10 UTC) #3
zra
lgtm
3 years, 9 months ago (2017-03-23 00:51:15 UTC) #4
rmacnak
3 years, 9 months ago (2017-03-23 01:14:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
442d177d3d78d362ddc03264869ee1c261eeff05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698