Remove enbale_xpc_notifications compile flag

chrome/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/compiler/pgo/pgo.gni")
 import("//build/config/features.gni")
 import("//build/config/locales.gni")
 import("//build/config/sanitizers/sanitizers.gni")
@@ skipping 469 matching lines @@
     }
 
     if (is_chrome_branded && is_official_build) {
       deps += [
         ":chrome_dsym_archive",
         ":chrome_dump_syms",
       ]
     }
   }
 
-  if (enable_xpc_notifications) {
-    bundle_data("chrome_framework_services") {
-      sources = [
-        "$root_out_dir/AlertNotificationService.xpc",
-      ]
+  bundle_data("chrome_framework_services") {
+    sources = [
+      "$root_out_dir/AlertNotificationService.xpc",
+    ]
 
-      outputs = [
-        "{{bundle_root_dir}}/XPCServices/{{source_file_part}}",
-      ]
+    outputs = [
+      "{{bundle_root_dir}}/XPCServices/{{source_file_part}}",
+    ]
 
-      public_deps = [
-        "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
-      ]
-    }
+    public_deps = [
+      "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
+    ]
   }
 
   tweak_info_plist("chrome_app_plist") {
     info_plist = "app/app-Info.plist"
     _keystone_arg = "0"
     if (is_chrome_branded) {
       _keystone_arg = "1"
     }
     args = [
       "--breakpad=0",
@@ skipping 582 matching lines @@
   }
 
   mac_framework_bundle("chrome_framework") {
     output_name = chrome_framework_name
 
     if (defined(chrome_framework_version)) {
       framework_version = chrome_framework_version
       framework_contents = [
         "Helpers",
         "Resources",
+        "XPCServices",
       ]
 
       if (is_chrome_branded) {
         framework_contents += [
           "Default Apps",
           "Frameworks",  # For KeystoneRegistration.framework.
         ]
       }
       if (enable_nacl) {
         framework_contents += [ "Internet Plug-Ins" ]
       }
       if (_should_bundle_widevine) {
         framework_contents += [ "Libraries" ]
       }
-      if (enable_xpc_notifications) {
-        framework_contents += [ "XPCServices" ]
-      }
     }
 
     configs += [ "//build/config/compiler:wexit_time_destructors" ]
 
     info_plist_target = ":chrome_framework_plist"
     extra_substitutions = [
       "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
       "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
     ]
 
     public_deps = [
       ":chrome_dll",
     ]
 
     deps = [
       ":chrome_framework_helpers",
       ":chrome_framework_plugins",
       ":chrome_framework_resources",
+      ":chrome_framework_services",
       ":packed_resources",
       ":widevine_cdm_library",
       "//build/config/sanitizers:deps",
       "//chrome/app/nibs:chrome_xibs",
     ]
 
     if (is_chrome_branded) {
       deps += [ ":default_apps" ]
     }
 
-    if (enable_xpc_notifications) {
-      deps += [ ":chrome_framework_services" ]
-    }
-
     ldflags = [
       "-Wl,-install_name,@executable_path/../Versions/$chrome_version_full/$chrome_framework_name.framework/$chrome_framework_name",
       "-compatibility_version",
       chrome_dylib_version,
       "-current_version",
       chrome_dylib_version,
       "-Wl,-order_file," + rebase_path("app/framework.order", root_build_dir),
     ]
 
     if (is_component_build) {
@@ skipping 55 matching lines @@
         ":chrome_framework",
       ]
     }
   }
 
   if (enable_dsyms) {
     # This list must be updated with the two targets' deps list below, and
     # the list of _dsyms in :chrome_dsym_archive.
     _chrome_symbols_sources = [
       _framework_binary_path,
+      "$root_out_dir/AlertNotificationService.xpc/Contents/MacOS/AlertNotificationService",
       "$root_out_dir/$chrome_helper_name.app/Contents/MacOS/$chrome_helper_name",
       "$root_out_dir/$chrome_product_full_name.app/Contents/MacOS/$chrome_product_full_name",
       "$root_out_dir/crashpad_handler",
     ]
 
-    if (enable_xpc_notifications) {
-      _chrome_symbols_sources += [ "$root_out_dir/AlertNotificationService.xpc/Contents/MacOS/AlertNotificationService" ]
-    }
-
     # It is possible to run dump_syms on unstripped products without dSYMs,
     # but doing so isn't logical and won't happen in practice.
     action_foreach("chrome_dump_syms") {
       script = "//build/redirect_stdout.py"
 
       sources = _chrome_symbols_sources
 
       outputs = [
         "$root_out_dir/{{source_file_part}}-$chrome_version_full.breakpad",
       ]
 
       # Use an absolute path to dump_syms in case a user has it in their path.
       args = rebase_path(outputs, root_out_dir) + [
                rebase_path("$root_out_dir/dump_syms"),
                "-g",
                rebase_path(
                    "$root_out_dir/{{source_name_part}}.dSYM/Contents/Resources/DWARF/{{source_name_part}}",
                    root_out_dir),
                "{{source}}",
              ]
 
       deps = [
         ":chrome_app",
         ":chrome_framework",
         ":chrome_helper_app",
         "//breakpad:dump_syms",
+        "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
         "//third_party/crashpad/crashpad/handler:crashpad_handler",
       ]
-
-      if (enable_xpc_notifications) {
-        deps += [ "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service" ]
-      }
     }
 
     action("chrome_dsym_archive") {
       script = "//chrome/tools/build/mac/archive_symbols.py"
 
       # These are the dSYMs that will be archived. The sources list must be
       # the target outputs that correspond to the dSYMs (since a dSYM is a
       # directory it cannot be listed as a source file). The targets that
       # generate both the dSYM and binary image are listed in deps.
       _dsyms = [
+        "$root_out_dir/AlertNotificationService.dSYM",
         "$root_out_dir/$chrome_framework_name.dSYM",
         "$root_out_dir/$chrome_helper_name.dSYM",
         "$root_out_dir/$chrome_product_full_name.dSYM",
         "$root_out_dir/crashpad_handler.dSYM",
       ]
 
-      if (enable_xpc_notifications) {
-        _dsyms += [ "$root_out_dir/AlertNotificationService.dSYM" ]
-      }
-
       sources = _chrome_symbols_sources
 
       _output = "$root_out_dir/$chrome_product_full_name.dSYM.tar.bz2"
 
       outputs = [
         _output,
       ]
 
       args = [ rebase_path(_output, root_out_dir) ] +
              rebase_path(_dsyms, root_out_dir)
 
       deps = [
         ":chrome_app",
         ":chrome_framework",
         ":chrome_helper_app",
+        "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service",
         "//third_party/crashpad/crashpad/handler:crashpad_handler",
       ]
-
-      if (enable_xpc_notifications) {
-        deps += [ "//chrome/browser/ui/cocoa/notifications:alert_notification_xpc_service" ]
-      }
     }
   } else {
     group("chrome_dump_syms") {
     }
     group("chrome_dsym_archive") {
     }
   }
 }
 
 group("browser_dependencies") {
@@ skipping 406 matching lines @@
       "//chrome/app/theme/$branding_path_component/product_logo_48.png",
       "//chrome/tools/build/linux/chrome-wrapper",
       "//third_party/xdg-utils/scripts/xdg-mime",
       "//third_party/xdg-utils/scripts/xdg-settings",
     ]
     outputs = [
       "$root_out_dir/{{source_file_part}}",
     ]
   }
 }