chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java - Issue 2774443002: chrome/android: Push EventFilters into the Layout implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

Issue 2774443002: chrome/android: Push EventFilters into the Layout implementations. (Closed)

Patch Set: fix for re-landing Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromeTablet.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/StaticLayout.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

index 348d78bd9a884667571b03b0c4152e716f88cae1..98f903f402905fbb54871b70dfa6a58a35a3b541 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java

@@ -22,7 +22,6 @@ import org.chromium.chrome.browser.compositor.layouts.components.VirtualView;

import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;

import org.chromium.chrome.browser.compositor.layouts.eventfilter.EdgeSwipeHandler;

import org.chromium.chrome.browser.compositor.layouts.eventfilter.EmptyEdgeSwipeHandler;

-import org.chromium.chrome.browser.compositor.layouts.eventfilter.GestureHandler;

import org.chromium.chrome.browser.compositor.layouts.eventfilter.ScrollDirection;

import org.chromium.chrome.browser.compositor.overlays.SceneOverlay;

import org.chromium.chrome.browser.compositor.scene_layer.ToolbarSceneLayer;

@@ -57,10 +56,6 @@ public class LayoutManagerDocument extends LayoutManager

// Event Filters

private final EdgeSwipeHandler mToolbarSwipeHandler;

- // Event Filter Handlers

- /** A {@link GestureHandler} that will delegate all events to {@link #getActiveLayout()}. */

- protected final GestureHandler mGestureHandler;

// Internal State

private final SparseArray<LayoutTab> mTabCache = new SparseArray<LayoutTab>();

private final ContextualSearchPanel mContextualSearchPanel;

@@ -86,7 +81,6 @@ public class LayoutManagerDocument extends LayoutManager

mToolbarOverlay = new ToolbarSceneLayer(mContext, this, renderHost);

// Build Event Filter Handlers

- mGestureHandler = new GestureHandlerLayoutDelegate(this);

mToolbarSwipeHandler = new ToolbarSwipeHandler(this);

mOverlayPanelManager = new OverlayPanelManager();