Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 277443004: Handle X11 Mod3Mask for Caps Lock remapping. (Closed)

Created:
6 years, 7 months ago by kpschoedel
Modified:
6 years, 7 months ago
Reviewers:
Daniel Erat, sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Handle X11 Mod3Mask for Caps Lock remapping. Mod3Mask is set on X events when the Caps Lock key is down, but, if Caps Lock is remapped, the X CapsLock flag is NOT set, because pressing the key does not invoke caps lock from X's point of view. So, have the kModifierRemappings[] table uses EF_MOD3_DOWN for the Caps Lock remapping. BUG=372796 R=derat@chromium.org TEST=manual on device Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270704

Patch Set 1 #

Patch Set 2 : Update unit tests with Mod3Mask #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -18 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 7 chunks +19 lines, -14 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
kpschoedel
6 years, 7 months ago (2014-05-13 22:31:45 UTC) #1
Daniel Erat
lgtm
6 years, 7 months ago (2014-05-13 23:14:31 UTC) #2
kpschoedel
The CQ bit was checked by kpschoedel@chromium.org
6 years, 7 months ago (2014-05-13 23:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/277443004/1
6 years, 7 months ago (2014-05-13 23:46:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 02:53:13 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 03:51:47 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/26373)
6 years, 7 months ago (2014-05-14 03:51:47 UTC) #7
kpschoedel
6 years, 7 months ago (2014-05-14 14:22:01 UTC) #8
kpschoedel
The CQ bit was checked by kpschoedel@chromium.org
6 years, 7 months ago (2014-05-14 14:22:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/277443004/20001
6 years, 7 months ago (2014-05-14 14:22:56 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 18:15:27 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 18:33:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/26668)
6 years, 7 months ago (2014-05-14 18:33:16 UTC) #13
kpschoedel
The CQ bit was checked by kpschoedel@chromium.org
6 years, 7 months ago (2014-05-14 21:55:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/277443004/20001
6 years, 7 months ago (2014-05-14 21:58:13 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-14 23:23:18 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-14 23:51:48 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27001)
6 years, 7 months ago (2014-05-14 23:51:49 UTC) #18
sadrul
LGTM
6 years, 7 months ago (2014-05-14 23:53:05 UTC) #19
kpschoedel
The CQ bit was checked by kpschoedel@chromium.org
6 years, 7 months ago (2014-05-15 13:56:21 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/277443004/20001
6 years, 7 months ago (2014-05-15 13:57:08 UTC) #21
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 17:04:05 UTC) #22
Message was sent while issue was closed.
Change committed as 270704

Powered by Google App Engine
This is Rietveld 408576698