Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: base/android/java_handler_thread.cc

Issue 2774363003: android: Java-based launcher thread (Closed)
Patch Set: gab review 2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/java_handler_thread.h ('k') | base/message_loop/message_loop_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/java_handler_thread.cc
diff --git a/base/android/java_handler_thread.cc b/base/android/java_handler_thread.cc
index 76ee301dbb6306a0e51ae71e9bd269d26a094438..0152198b743d5b4c07c2ea9670b7a7399d7ef35f 100644
--- a/base/android/java_handler_thread.cc
+++ b/base/android/java_handler_thread.cc
@@ -13,16 +13,20 @@
#include "base/threading/thread_restrictions.h"
#include "jni/JavaHandlerThread_jni.h"
+using base::android::AttachCurrentThread;
+
namespace base {
namespace android {
-JavaHandlerThread::JavaHandlerThread(const char* name) {
- JNIEnv* env = base::android::AttachCurrentThread();
+JavaHandlerThread::JavaHandlerThread(const char* name)
+ : JavaHandlerThread(Java_JavaHandlerThread_create(
+ AttachCurrentThread(),
+ ConvertUTF8ToJavaString(AttachCurrentThread(), name))) {}
- java_thread_.Reset(
- Java_JavaHandlerThread_create(env, ConvertUTF8ToJavaString(env, name)));
-}
+JavaHandlerThread::JavaHandlerThread(
+ const base::android::ScopedJavaLocalRef<jobject>& obj)
+ : java_thread_(obj) {}
JavaHandlerThread::~JavaHandlerThread() {
}
@@ -35,9 +39,9 @@ void JavaHandlerThread::Start() {
base::WaitableEvent initialize_event(
WaitableEvent::ResetPolicy::AUTOMATIC,
WaitableEvent::InitialState::NOT_SIGNALED);
- Java_JavaHandlerThread_start(env, java_thread_,
- reinterpret_cast<intptr_t>(this),
- reinterpret_cast<intptr_t>(&initialize_event));
+ Java_JavaHandlerThread_startAndInitialize(
+ env, java_thread_, reinterpret_cast<intptr_t>(this),
+ reinterpret_cast<intptr_t>(&initialize_event));
// Wait for thread to be initialized so it is ready to be used when Start
// returns.
base::ThreadRestrictions::ScopedAllowWait wait_allowed;
« no previous file with comments | « base/android/java_handler_thread.h ('k') | base/message_loop/message_loop_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698