Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: Source/core/css/parser/MediaQueryParser.cpp

Issue 277433002: MQParser memory leak fix (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/css/CSSParserValues.cpp ('K') | « Source/core/css/CSSParserValues.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/MediaQueryParser.cpp
diff --git a/Source/core/css/parser/MediaQueryParser.cpp b/Source/core/css/parser/MediaQueryParser.cpp
index 24df5653616d81cc382fe07c1fe57a947c2d3802..ec3bfe0e09ac297f8bace6f0942fdc4373fc7b78 100644
--- a/Source/core/css/parser/MediaQueryParser.cpp
+++ b/Source/core/css/parser/MediaQueryParser.cpp
@@ -214,7 +214,7 @@ void MediaQueryData::clear()
m_mediaType = MediaTypeNames::all;
m_mediaTypeSet = false;
m_mediaFeature = String();
- m_valueList.clear();
+ m_valueList.destroyAndClear();
m_expressions = adoptPtrWillBeNoop(new ExpressionHeapVector);
}
@@ -230,7 +230,7 @@ bool MediaQueryData::addExpression()
OwnPtrWillBeRawPtr<MediaQueryExp> expression = MediaQueryExp::createIfValid(m_mediaFeature, &m_valueList);
bool isValid = !!expression;
m_expressions->append(expression.release());
- m_valueList.clear();
+ m_valueList.destroyAndClear();
return isValid;
}
« Source/core/css/CSSParserValues.cpp ('K') | « Source/core/css/CSSParserValues.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698