Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: chrome/browser/ui/views/payments/payment_request_can_make_payment_browsertest.cc

Issue 2774253002: Disable flaky PaymentRequestCanMakePaymentQueryTest.CanMakePayment_Supported (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/ui/views/payments/payment_request_browsertest_base.h" 9 #include "chrome/browser/ui/views/payments/payment_request_browsertest_base.h"
10 #include "components/autofill/core/browser/autofill_test_utils.h" 10 #include "components/autofill/core/browser/autofill_test_utils.h"
(...skipping 11 matching lines...) Expand all
22 22
23 void CallCanMakePayment() { 23 void CallCanMakePayment() {
24 ASSERT_TRUE(content::ExecuteScript(GetActiveWebContents(), "buy();")); 24 ASSERT_TRUE(content::ExecuteScript(GetActiveWebContents(), "buy();"));
25 } 25 }
26 26
27 private: 27 private:
28 DISALLOW_COPY_AND_ASSIGN(PaymentRequestCanMakePaymentQueryTest); 28 DISALLOW_COPY_AND_ASSIGN(PaymentRequestCanMakePaymentQueryTest);
29 }; 29 };
30 30
31 // Visa is required, and user has a visa instrument. 31 // Visa is required, and user has a visa instrument.
32 // Test is flaky on ChromeOS. crbug.com/705225
33 #if defined(OS_CHROMEOS)
34 #define MAYBE_CanMakePayment_Supported DISABLED_CanMakePayment_Supported
35 #else
36 #define MAYBE_CanMakePayment_Supported CanMakePayment_Supported
37 #endif
32 IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentQueryTest, 38 IN_PROC_BROWSER_TEST_F(PaymentRequestCanMakePaymentQueryTest,
33 CanMakePayment_Supported) { 39 MAYBE_CanMakePayment_Supported) {
34 const autofill::CreditCard card = autofill::test::GetCreditCard(); // Visa. 40 const autofill::CreditCard card = autofill::test::GetCreditCard(); // Visa.
35 AddCreditCard(card); 41 AddCreditCard(card);
36 42
37 CallCanMakePayment(); 43 CallCanMakePayment();
38 44
39 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("true")}); 45 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("true")});
40 } 46 }
41 47
42 // Visa is required, and user has a visa instrument, and user is in incognito 48 // Visa is required, and user has a visa instrument, and user is in incognito
43 // mode. 49 // mode.
(...skipping 30 matching lines...) Expand all
74 AddCreditCard(card); 80 AddCreditCard(card);
75 81
76 CallCanMakePayment(); 82 CallCanMakePayment();
77 83
78 // Returns true because the user is in incognito mode, even though it should 84 // Returns true because the user is in incognito mode, even though it should
79 // return false in a normal profile. 85 // return false in a normal profile.
80 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("true")}); 86 ExpectBodyContains(std::vector<base::string16>{base::ASCIIToUTF16("true")});
81 } 87 }
82 88
83 } // namespace payments 89 } // namespace payments
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698