third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp - Issue 2774233007: [Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

Issue 2774233007: [Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty (Closed)

Patch Set: workaround Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8EventListenerHelper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

index 222c27d94e6016c5e64b0a273fd9825de080d1f1..5819e2cba98c99f7152d5bff2411ad738ea89fe0 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

@@ -431,6 +431,8 @@ TEST_F(ScriptPromisePropertyGarbageCollectedTest, Resolve_DeadContext) {

}

TEST_F(ScriptPromisePropertyGarbageCollectedTest, Reset) {

+ ScriptState::Scope scope(mainScriptState());

ScriptPromise oldPromise, newPromise;

ScriptValue oldActual, newActual;

GarbageCollectedScriptWrappable* oldValue =