Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h

Issue 2774233007: [Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty (Closed)
Patch Set: workaround Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
index 5941546bfdcb1b928e7e189590751c2bb0c2daad..6277cb658cc97376a6c76f63335ada7f1bbd0517 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
@@ -10,6 +10,7 @@
#include "bindings/core/v8/ScopedPersistent.h"
#include "bindings/core/v8/ScriptPromise.h"
#include "bindings/core/v8/ScriptPromiseProperties.h"
+#include "bindings/core/v8/V8PrivateProperty.h"
#include "core/CoreExport.h"
#include "core/dom/ContextLifecycleObserver.h"
#include "platform/wtf/Compiler.h"
@@ -33,7 +34,7 @@ class CORE_EXPORT ScriptPromisePropertyBase
virtual ~ScriptPromisePropertyBase();
enum Name {
-#define P(Name) Name,
+#define P(Unused, Name) Name,
SCRIPT_PROMISE_PROPERTIES(P)
#undef P
};
@@ -83,8 +84,8 @@ class CORE_EXPORT ScriptPromisePropertyBase
NEVER_INLINE void checkThis();
NEVER_INLINE void checkWrappers();
- v8::Local<v8::String> promiseName();
- v8::Local<v8::String> resolverName();
+ V8PrivateProperty::Symbol promiseSymbol();
+ V8PrivateProperty::Symbol resolverSymbol();
v8::Isolate* m_isolate;
Name m_name;

Powered by Google App Engine
This is Rietveld 408576698