[Bindings] Move ScriptPromiseProperties from V8HiddenValue to V8PrivateProperty

third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/ScriptPromisePropertyBase.h"
 
 #include <memory>
 #include "bindings/core/v8/ScopedPersistent.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/V8Binding.h"
@@ skipping 22 matching lines @@
   v8::HandleScope handleScope(m_isolate);
   v8::Local<v8::Context> context = toV8Context(getExecutionContext(), world);
   if (context.IsEmpty())
     return ScriptPromise();
   ScriptState* scriptState = ScriptState::from(context);
   ScriptState::Scope scope(scriptState);
 
   v8::Local<v8::Object> wrapper = ensureHolderWrapper(scriptState);
   DCHECK(wrapper->CreationContext() == context);
 
-  v8::Local<v8::Value> cachedPromise =
-      V8HiddenValue::getHiddenValue(scriptState, wrapper, promiseName());
-  if (!cachedPromise.IsEmpty() && cachedPromise->IsPromise())
+  v8::Local<v8::Value> cachedPromise = promiseSymbol().getOrUndefined(wrapper);
+  if (!cachedPromise->IsUndefined() && cachedPromise->IsPromise())
     return ScriptPromise(scriptState, cachedPromise);
 
   // Create and cache the Promise
   v8::Local<v8::Promise::Resolver> resolver;
   if (!v8::Promise::Resolver::New(context).ToLocal(&resolver))
     return ScriptPromise();
   v8::Local<v8::Promise> promise = resolver->GetPromise();
-  V8HiddenValue::setHiddenValue(scriptState, wrapper, promiseName(), promise);
+  promiseSymbol().set(wrapper, promise);
 
   switch (m_state) {
     case Pending:
       // Cache the resolver too
-      V8HiddenValue::setHiddenValue(scriptState, wrapper, resolverName(),
-                                    resolver);
+      resolverSymbol().set(wrapper, resolver);
       break;
     case Resolved:
     case Rejected:
       resolveOrRejectInternal(resolver);
       break;
   }
 
   return ScriptPromise(scriptState, promise);
 }
 
@@ skipping 13 matching lines @@
       // wrapper has died.
       // Since v8 GC can run during the iteration and clear the reference,
       // we can't move this check out of the loop.
       m_wrappers.erase(i);
       continue;
     }
     v8::Local<v8::Object> wrapper = persistent->newLocal(m_isolate);
     ScriptState* scriptState = ScriptState::from(wrapper->CreationContext());
     ScriptState::Scope scope(scriptState);
 
+    V8PrivateProperty::Symbol symbol = resolverSymbol();
+    DCHECK(symbol.hasValue(wrapper));
     v8::Local<v8::Promise::Resolver> resolver =
-        V8HiddenValue::getHiddenValue(scriptState, wrapper, resolverName())
-            .As<v8::Promise::Resolver>();
-    DCHECK(!resolver.IsEmpty());
+        symbol.getOrUndefined(wrapper).As<v8::Promise::Resolver>();
 
-    V8HiddenValue::deleteHiddenValue(scriptState, wrapper, resolverName());
+    symbol.deleteProperty(wrapper);
     resolveOrRejectInternal(resolver);
     ++i;
   }
 }
 
 void ScriptPromisePropertyBase::resetBase() {
   checkThis();
   clearWrappers();
   m_state = Pending;
 }
@@ skipping 47 matching lines @@
 }
 
 void ScriptPromisePropertyBase::clearWrappers() {
   checkThis();
   checkWrappers();
   v8::HandleScope handleScope(m_isolate);
   for (WeakPersistentSet::iterator i = m_wrappers.begin();
        i != m_wrappers.end(); ++i) {
     v8::Local<v8::Object> wrapper = (*i)->newLocal(m_isolate);
     if (!wrapper.IsEmpty()) {
-      ScriptState* scriptState = ScriptState::from(wrapper->CreationContext());
-      V8HiddenValue::deleteHiddenValue(scriptState, wrapper, resolverName());
-      V8HiddenValue::deleteHiddenValue(scriptState, wrapper, promiseName());
+      resolverSymbol().deleteProperty(wrapper);
+      // TODO(peria): Use deleteProperty() if http://crbug.com/v8/6227 is fixed.
+      promiseSymbol().set(wrapper, v8::Undefined(m_isolate));

[peria, 2017/04/07 09:43:37]

v8::Object::DeleteProperty() seems to have a bug if we build with
dcheck_always_on (and some other flags may be needed), and the behavior of
V8HiddenValue::deleteHiddenValue() was to set v8::Undefined(), so I set
Undefined here as a workaround.

     }
   }
   m_wrappers.clear();
 }
 
 void ScriptPromisePropertyBase::checkThis() {
   RELEASE_ASSERT(this);
 }
 
 void ScriptPromisePropertyBase::checkWrappers() {
   for (WeakPersistentSet::iterator i = m_wrappers.begin();
        i != m_wrappers.end(); ++i) {
     RELEASE_ASSERT(*i);
   }
 }
 
-v8::Local<v8::String> ScriptPromisePropertyBase::promiseName() {
+V8PrivateProperty::Symbol ScriptPromisePropertyBase::promiseSymbol() {
   switch (m_name) {
-#define P(Name) \
-  case Name:    \
-    return V8HiddenValue::Name##Promise(m_isolate);
+#define P(Interface, Name)                                     \
+  case Name:                                                   \
+    return V8PrivateProperty::V8_PRIVATE_PROPERTY_GETTER_NAME( \
+        Interface, Name##Promise)(m_isolate);
 
     SCRIPT_PROMISE_PROPERTIES(P)
 
 #undef P
   }
-  ASSERT_NOT_REACHED();
-  return v8::Local<v8::String>();
+  NOTREACHED();
+  return V8PrivateProperty::getSymbol(m_isolate, "noPromise");
 }
 
-v8::Local<v8::String> ScriptPromisePropertyBase::resolverName() {
+V8PrivateProperty::Symbol ScriptPromisePropertyBase::resolverSymbol() {
   switch (m_name) {
-#define P(Name) \
-  case Name:    \
-    return V8HiddenValue::Name##Resolver(m_isolate);
+#define P(Interface, Name)                                     \
+  case Name:                                                   \
+    return V8PrivateProperty::V8_PRIVATE_PROPERTY_GETTER_NAME( \
+        Interface, Name##Resolver)(m_isolate);
 
     SCRIPT_PROMISE_PROPERTIES(P)
 
 #undef P
   }
-  ASSERT_NOT_REACHED();
-  return v8::Local<v8::String>();
+  NOTREACHED();
+  return V8PrivateProperty::getSymbol(m_isolate, "noResolver");
 }
 
 DEFINE_TRACE(ScriptPromisePropertyBase) {
   ContextClient::trace(visitor);
 }
 
 }  // namespace blink