Issue 2774233003: Cleanups needed for async step-out

Issue 2774233003: Cleanups needed for async step-out (Closed)

Created:
3 years, 8 months ago by Cutch

Modified:
3 years, 8 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cleanups needed for async step-out BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/11cf515e5ebe163edf93106bed8dc7ff1061e447

Patch Set 1 #

Total comments: 2

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -34 lines)			Patch
M	runtime/lib/async_patch.dart	View	1 chunk	+4 lines, -0 lines	2 comments	Download
M	runtime/vm/debugger.cc	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/object_store.h	View	2 chunks	+16 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	3 chunks	+34 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

lgtm https://codereview.chromium.org/2774233003/diff/1/runtime/lib/async_patch.dart File runtime/lib/async_patch.dart (right): https://codereview.chromium.org/2774233003/diff/1/runtime/lib/async_patch.dart#newcode245 runtime/lib/async_patch.dart:245: void _completeOnAsyncReturn(Object completer, [value]) { You always call ...

3 years, 8 months ago (2017-03-27 21:05:52 UTC) #4

Cutch

Committed patchset #1 (id:1) manually as 11cf515e5ebe163edf93106bed8dc7ff1061e447 (presubmit successful).

3 years, 8 months ago (2017-03-27 22:18:48 UTC) #6

Cutch

3 years, 8 months ago (2017-03-27 22:31:21 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/2774233003/diff/1/runtime/lib/async_patch.dart
File runtime/lib/async_patch.dart (right):

https://codereview.chromium.org/2774233003/diff/1/runtime/lib/async_patch.dar...
runtime/lib/async_patch.dart:245: void _completeOnAsyncReturn(Object completer,
[value]) {
On 2017/03/27 21:05:51, rmacnak wrote:
> You always call this with both arguments, so don't make [value] optional.

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages