Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1776)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sandbox/linux/BUILD.gn

Issue 2774223005: Enable -Wshift-negative-value. (Closed)
Patch Set: sandbox Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/BUILD.gn
diff --git a/sandbox/linux/BUILD.gn b/sandbox/linux/BUILD.gn
index 3e98defa5c612f298631edb395a8146c82436edf..1dab49ca44d328ffeec2e76542e2d9abf638beae 100644
--- a/sandbox/linux/BUILD.gn
+++ b/sandbox/linux/BUILD.gn
@@ -146,6 +146,11 @@ source_set("sandbox_linux_unittests_sources") {
"seccomp-bpf/trap_unittest.cc",
]
deps += [ ":bpf_dsl_golden" ]
+
+ # syscall_parameters_restrictions_unittests.cc uses MAKE_PROCESS_CPUCLOCK,
+ # which shifts signed ints around, which has undefined behavior.
+ # TODO(thakis): Fix that in LSS, then remove this flag here.
Nico 2017/03/30 16:09:34 rsesek: I actually tried to do this so I'm not blo
+ cflags = [ "-Wno-shift-negative-value" ]
}
if (compile_credentials) {
sources += [
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698