third_party/WebKit/Source/web/CompositorMutatorImpl.cpp - Issue 2774223002: CompositorWorkerProxyClientImpl to CompositorProxy cross thread reference is using WeakMember

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

Issue 2774223002: CompositorWorkerProxyClientImpl to CompositorProxy cross thread reference is using WeakMember (Closed)

Patch Set: fix Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

diff --git a/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp b/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

index a7d835295758a21c7d0ee4caae64ddebbcba075f..f1287dcb3257e1877e91784d5307123bade4018a 100644

--- a/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

+++ b/third_party/WebKit/Source/web/CompositorMutatorImpl.cpp

@@ -76,6 +76,7 @@ bool CompositorMutatorImpl::mutate(

void CompositorMutatorImpl::registerCompositorAnimator(

CompositorAnimator* animator) {

+ DCHECK(!isMainThread());

TRACE_EVENT0("compositor-worker",

"CompositorMutatorImpl::registerCompositorAnimator");

DCHECK(!m_animators.contains(animator));

@@ -90,6 +91,7 @@ void CompositorMutatorImpl::unregisterCompositorAnimator(

}

void CompositorMutatorImpl::setNeedsMutate() {

+ DCHECK(!isMainThread());

TRACE_EVENT0("compositor-worker", "CompositorMutatorImpl::setNeedsMutate");

m_client->setNeedsMutate();

}