Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/web/CompositorProxyClientImpl.h

Issue 2774223002: CompositorWorkerProxyClientImpl to CompositorProxy cross thread reference is using WeakMember (Closed)
Patch Set: Added comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/CompositorProxyClientImpl.h
diff --git a/third_party/WebKit/Source/web/CompositorProxyClientImpl.h b/third_party/WebKit/Source/web/CompositorProxyClientImpl.h
new file mode 100644
index 0000000000000000000000000000000000000000..5433d67a8a6713c98b418e033162974bf3e42183
--- /dev/null
+++ b/third_party/WebKit/Source/web/CompositorProxyClientImpl.h
@@ -0,0 +1,37 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CompositorProxyClientImpl_h
+#define CompositorProxyClientImpl_h
+
+#include "core/dom/CompositorProxyClient.h"
+
+namespace blink {
+
+// Registery for CompositorProxies on the control thread.
flackr 2017/04/04 02:17:07 nit: s/Registery/Registry
keishi 2017/04/04 05:54:43 Done.
+// Owned by the control thread.
+class CompositorProxyClientImpl
+ : public GarbageCollectedFinalized<CompositorProxyClientImpl>,
+ public CompositorProxyClient {
+ USING_GARBAGE_COLLECTED_MIXIN(CompositorProxyClientImpl);
+
+ public:
+ DECLARE_TRACE();
+
+ // CompositorProxyClient:
+ void registerCompositorProxy(CompositorProxy*) override;
+ void unregisterCompositorProxy(CompositorProxy*) override;
+
+ HeapHashSet<WeakMember<CompositorProxy>>& proxies() { return m_proxies; }
+
+ private:
+ // CompositorProxy can be constructed in the main thread and control thread.
+ // However this only ever contains ones constructed in the compositor worker
+ // thread.
+ HeapHashSet<WeakMember<CompositorProxy>> m_proxies;
+};
+
+} // namespace blink
+
+#endif // CompositorProxyClientImpl_h

Powered by Google App Engine
This is Rietveld 408576698