Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.h

Issue 2774223002: CompositorWorkerProxyClientImpl to CompositorProxy cross thread reference is using WeakMember (Closed)
Patch Set: fix Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.h
diff --git a/third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.h b/third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.h
index 2a3a9051bab0ee6e4753a856b9a209fba9762095..d06108496a7d2344e2df06d337538cec1d5582e6 100644
--- a/third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.h
+++ b/third_party/WebKit/Source/core/dom/AnimationWorkletProxyClient.h
@@ -11,11 +11,14 @@
namespace blink {
-class CORE_EXPORT AnimationWorkletProxyClient : public CompositorProxyClient {
+class CORE_EXPORT AnimationWorkletProxyClient
sof 2017/03/29 05:51:05 What role does this abstraction play? i.e., it's n
keishi 2017/03/30 08:34:14 I think it's suppose to be an interface so it can
+ : public GarbageCollectedFinalized<AnimationWorkletProxyClient> {
WTF_MAKE_NONCOPYABLE(AnimationWorkletProxyClient);
public:
AnimationWorkletProxyClient() {}
+ virtual ~AnimationWorkletProxyClient() {}
+ DEFINE_INLINE_VIRTUAL_TRACE() {}
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698