Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/BUILD.gn

Issue 2774203002: Migrate about:flags messages to const char* (Closed)
Patch Set: iOS OWNERS Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index d227eff23070baa628a26e68d38d359f2993695e..4e17d1a9b936a8061e8e9780873fb8a707d4a20a 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -406,6 +406,8 @@ split_static_library("browser") {
"file_select_helper.cc",
"file_select_helper.h",
"file_select_helper_mac.mm",
+ "flags_descriptions.cc",
+ "flags_descriptions.h",
agrieve 2017/03/27 15:43:24 Super nit: "flag_descriptions.*" would sound bette
Alexei Svitkine (slow) 2017/03/27 16:37:28 We're not doing it for the other source files... s
vabr (Chromium) 2017/03/27 16:48:25 I think agrieve@ meant I keep "flags" singular: "f
Alexei Svitkine (slow) 2017/03/27 16:55:39 Oops, I did indeed misread that comment. :)
vabr (Chromium) 2017/03/27 18:12:33 Done.
"fullscreen.h",
"fullscreen_chromeos.cc",
"fullscreen_mac.mm",

Powered by Google App Engine
This is Rietveld 408576698