Migrate about:flags messages to const char*

components/flags_ui/flags_state.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/flags_ui/flags_state.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/callback.h"
@@ skipping 492 matching lines @@
 
   int current_platform = GetCurrentPlatform();
 
   for (size_t i = 0; i < num_feature_entries_; ++i) {
     const FeatureEntry& entry = feature_entries_[i];
     if (skip_feature_entry.Run(entry))
       continue;
 
     std::unique_ptr<base::DictionaryValue> data(new base::DictionaryValue());
     data->SetString("internal_name", entry.internal_name);
-    data->SetString("name", l10n_util::GetStringUTF16(entry.visible_name_id));
-    data->SetString("description",
-                    l10n_util::GetStringUTF16(entry.visible_description_id));
+    data->SetString("name",
+                    base::UTF8ToUTF16(base::StringPiece(entry.visible_name)));

[Alexei Svitkine (slow), 2017/03/27 16:37:29]

Looks like SetString() accepts a StringPiece as the second param:

https://cs.chromium.org/chromium/src/base/values.h?rcl=0e44ebc7dcf7c343d45694...

So no need to do our own UTF8ToUTF16 here. Same below.

[vabr (Chromium), 2017/03/27 18:12:33]

Thanks for catching this, it would have been indeed a silly thing to do, with
base::Value actually storing the 8-byte string.

+    data->SetString(
+        "description",
+        base::UTF8ToUTF16(base::StringPiece(entry.visible_description)));
 
     base::ListValue* supported_platforms = new base::ListValue();
     AddOsStrings(entry.supported_platforms, supported_platforms);
     data->Set("supported_platforms", supported_platforms);
     // True if the switch is not currently passed.
     bool is_default_value = IsDefaultValue(entry, enabled_entries);
     data->SetBoolean("is_default", is_default_value);
 
     switch (entry.type) {
       case FeatureEntry::SINGLE_VALUE:
@@ skipping 268 matching lines @@
                               state == FeatureEntry::FeatureState::ENABLED,
                               name_to_switch_map);
           }
         }
         break;
     }
   }
 }
 
 }  // namespace flags_ui