Issue 2774143002: Displaying URL in the context menu without '%'-escaped chars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2774143002: Displaying URL in the context menu without '%'-escaped chars

Created:
3 years, 9 months ago by marcin

Modified:
3 years, 9 months ago

Reviewers:
Maria

CC:
chromium-reviews, agrieve+watch_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Displaying URL in the context menu without '%'-escaped chars BUG=705233

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Maria

3 years, 9 months ago (2017-03-27 15:59:34 UTC) #4

On 2017/03/25 19:49:20, marcin wrote:

Hi,

This looks like it's related to crbug.com/680673. Please follow up with your
original reviewers as I believe there were concerns about the original patch.

Context menu is not my area of expertise, so I will defer to others to make the
decisions here / do the code review.

Thanks,
Maria

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages