Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5889)

Unified Diff: Source/modules/screen_orientation/ScreenOrientationController.h

Issue 277413002: Make screen.orientation implementation use WebScreenInfo::orientationType (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add FIXME comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/screen_orientation/ScreenOrientationController.h
diff --git a/Source/modules/screen_orientation/ScreenOrientationController.h b/Source/modules/screen_orientation/ScreenOrientationController.h
index 81d24fdc4747aa3df50a9cd735363c9d6de367b1..5bc56f45f991c8450fbd150323310d990e5c08ec 100644
--- a/Source/modules/screen_orientation/ScreenOrientationController.h
+++ b/Source/modules/screen_orientation/ScreenOrientationController.h
@@ -10,16 +10,14 @@
namespace WebCore {
+class FrameView;
+
class ScreenOrientationController FINAL : public NoBaseWillBeGarbageCollected<ScreenOrientationController>, public DocumentSupplement {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientationController);
public:
-#if !ENABLE(OILPAN)
virtual ~ScreenOrientationController();
-#endif
-
- void didChangeScreenOrientation(blink::WebScreenOrientationType);
- blink::WebScreenOrientationType orientation() const { return m_orientation; }
+ blink::WebScreenOrientationType orientation() const;
// DocumentSupplement API.
static ScreenOrientationController& from(Document&);
@@ -27,11 +25,9 @@ public:
private:
explicit ScreenOrientationController(Document&);
-
- void dispatchOrientationChangeEvent();
+ static blink::WebScreenOrientationType computeOrientation(FrameView*);
Document& m_document;
- blink::WebScreenOrientationType m_orientation;
};
} // namespace WebCore
« no previous file with comments | « Source/modules/modules.gypi ('k') | Source/modules/screen_orientation/ScreenOrientationController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698