Make screen.orientation implementation use WebScreenInfo::orientationType

Source/modules/screen_orientation/ScreenOrientationController.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/screen_orientation/ScreenOrientationController.h"
 
 #include "core/dom/Document.h"
 #include "core/events/Event.h"
 #include "core/frame/DOMWindow.h"
+#include "core/frame/FrameView.h"
+#include "core/frame/LocalFrame.h"
 #include "core/frame/Screen.h"
-#include "modules/screen_orientation/ScreenOrientationDispatcher.h"
+#include "platform/LayoutTestSupport.h"
+#include "platform/PlatformScreen.h"
 
 namespace WebCore {
 
-#if !ENABLE(OILPAN)
 ScreenOrientationController::~ScreenOrientationController()
 {
-    // With oilpan, weak processing removes the controller once it is dead.
-    ScreenOrientationDispatcher::instance().removeController(this);
 }
-#endif
 
 ScreenOrientationController& ScreenOrientationController::from(Document& document)
 {
     ScreenOrientationController* controller = static_cast<ScreenOrientationController*>(DocumentSupplement::from(document, supplementName()));
     if (!controller) {
         controller = new ScreenOrientationController(document);
         DocumentSupplement::provideTo(document, supplementName(), adoptPtrWillBeNoop(controller));
     }
     return *controller;
 }
 
 ScreenOrientationController::ScreenOrientationController(Document& document)
     : m_document(document)
-    , m_orientation(blink::WebScreenOrientationPortraitPrimary)
 {
-    // FIXME: We should listen for screen orientation change events only when the page is visible.
-    ScreenOrientationDispatcher::instance().addController(this);
-}
-
-void ScreenOrientationController::dispatchOrientationChangeEvent()
-{
-    if (m_document.domWindow()
-        && !m_document.activeDOMObjectsAreSuspended()
-        && !m_document.activeDOMObjectsAreStopped())
-        m_document.domWindow()->dispatchEvent(Event::create(EventTypeNames::orientationchange));
 }
 
 const char* ScreenOrientationController::supplementName()
 {
     return "ScreenOrientationController";
 }
 
-void ScreenOrientationController::didChangeScreenOrientation(blink::WebScreenOrientationType orientation)
+// Compute the screen orientation using the orientation angle and the screen width / height.
+blink::WebScreenOrientationType ScreenOrientationController::computeOrientation(FrameView* view)
 {
-    if (orientation == m_orientation)
-        return;
+    // Bypass orientation detection in layout tests to get consistent results.
+    if (isRunningLayoutTest())
+        return blink::WebScreenOrientationPortraitPrimary;

[jochen (gone - plz use gerrit), 2014/05/26 10:02:11]

i thought we use fixed widht/height during layout tests?

[Inactive, 2014/05/26 16:42:38]

I will double check but last I checked (not long ago) we weren't.

[Inactive, 2014/05/27 14:22:15]

I have just verified that screen.width returns 1920 in the layout test which is
my actual desktop screen width. I don't believe we are using a fixed width /
height in the layout tests.

 
-    m_orientation = orientation;
-    dispatchOrientationChangeEvent();
+    FloatRect rect = screenRect(view);
+    uint16_t rotation = screenOrientationAngle(view);
+    bool isTallDisplay = rotation % 180 ? rect.height() < rect.width() : rect.height() > rect.width();
+    switch (rotation) {
+    case 0:
+        return isTallDisplay ? blink::WebScreenOrientationPortraitPrimary : blink::WebScreenOrientationLandscapePrimary;
+    case 90:
+        return isTallDisplay ? blink::WebScreenOrientationLandscapePrimary : blink::WebScreenOrientationPortraitSecondary;
+    case 180:
+        return isTallDisplay ? blink::WebScreenOrientationPortraitSecondary : blink::WebScreenOrientationLandscapeSecondary;
+    case 270:
+        return isTallDisplay ? blink::WebScreenOrientationLandscapeSecondary : blink::WebScreenOrientationPortraitPrimary;
+    default:
+        ASSERT_NOT_REACHED();
+        return blink::WebScreenOrientationPortraitPrimary;
+    }
+}
+
+blink::WebScreenOrientationType ScreenOrientationController::orientation() const
+{
+    LocalFrame* mainFrame = m_document.frame();
+    if (!mainFrame)
+        return blink::WebScreenOrientationPortraitPrimary;
+    blink::WebScreenOrientationType orientationType = screenOrientationType(mainFrame->view());
+    if (orientationType == blink::WebScreenOrientationUndefined) {
+        // The embedder could not provide us with an orientation, deduce it ourselves.
+        orientationType = computeOrientation(mainFrame->view());
+    }
+    ASSERT(orientationType != blink::WebScreenOrientationUndefined);
+    return orientationType;
 }
 
 } // namespace WebCore